Skip to content

Conversation

@TheNeuralBit
Copy link
Contributor

I noticed that these doctests lost some formatting in a refactor. It's a little surprising the tests were still passing, presumably doctests is configured to ignore leading whitespace?

@jreback jreback added the Docs label Mar 11, 2021
@jreback jreback added this to the 1.3 milestone Mar 11, 2021
@jreback jreback merged commit d7c8ae7 into pandas-dev:master Mar 11, 2021
@jreback
Copy link
Contributor

jreback commented Mar 11, 2021

thanks @TheNeuralBit i don't think doctests care about the actual whitespace match (though its possible we also runing these specific ones).

jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Mar 11, 2021
@TheNeuralBit
Copy link
Contributor Author

I also modified the output and confirmed that it failed when running ./ci/code_checks.sh doctests so I think you're right that its ignoring whitespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants