Skip to content

STYLE: Inconsistent namespace - resample #39992 #40220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2021
Merged

STYLE: Inconsistent namespace - resample #39992 #40220

merged 3 commits into from
Mar 4, 2021

Conversation

@thomasyu888
Copy link
Contributor

@thomasyu888 thomasyu888 commented Mar 4, 2021

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@thomasyu888
Copy link
Contributor Author

thomasyu888 commented Mar 4, 2021 •
edited
Loading

Linking: #39992

@gfyoung gfyoung added the Code Style Code style, linting, code_checks label Mar 4, 2021
@gfyoung
Copy link
Member

gfyoung commented Mar 4, 2021

CI notwithstanding, LGTM!

@MarcoGorelli MarcoGorelli added this to the 1.3 milestone Mar 4, 2021
@MarcoGorelli MarcoGorelli merged commit fda70c0 into pandas-dev:master Mar 4, 2021
@MarcoGorelli
Copy link
Member

MarcoGorelli commented Mar 4, 2021

Thanks @thomasyu888

@thomasyu888 thomasyu888 deleted the resample-style branch March 4, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Code Style Code style, linting, code_checks

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

3 participants

@thomasyu888 @gfyoung @MarcoGorelli