Skip to content

BUG: maybe_convert_objects with timedelta64 nat #40062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2021
Merged

BUG: maybe_convert_objects with timedelta64 nat #40062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43197f0
BUG: maybe_convert_objects with timedelta64 nat
jbrockmendel Feb 25, 2021
56e681e
Merge branch 'master' into bug-maybe_infer_objects-td
jbrockmendel Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/_libs/lib.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2250,7 +2250,7 @@ def maybe_convert_objects(ndarray[object] objects, bint try_float=False,
break
elif is_timedelta(val):
if convert_timedelta:
itimedeltas[i] = convert_to_timedelta64(val, 'ns')
itimedeltas[i] = convert_to_timedelta64(val, "ns").view("i8")
seen.timedelta_ = True
else:
seen.object_ = True
Expand Down
10 changes: 10 additions & 0 deletions pandas/tests/dtypes/test_inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,16 @@ def test_maybe_convert_objects_datetime(self):
out = lib.maybe_convert_objects(arr, convert_datetime=1, convert_timedelta=1)
tm.assert_numpy_array_equal(out, exp)

def test_maybe_convert_objects_timedelta64_nat(self):
obj = np.timedelta64("NaT", "ns")
arr = np.array([obj], dtype=object)
assert arr[0] is obj

result = lib.maybe_convert_objects(arr, convert_timedelta=True)

expected = np.array([obj], dtype="m8[ns]")
tm.assert_numpy_array_equal(result, expected)

@pytest.mark.parametrize(
"exp",
[
Expand Down