DEP: bump min version of openpyxl to 3.0.0 #39603 #39702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangchenli
added
Dependencies
Contributor
|
cc @rhshadrach |
rhshadrach
requested changes
Feb 9, 2021
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
There are also some version checks in the openpyxl tests that can be removed/simplified.
rhshadrach
requested changes
Feb 11, 2021
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
Small request, rest look great!
Contributor
|
thanks @fangchenli |
znicholls
pushed a commit
to znicholls/pandas
that referenced
this pull request
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.