Skip to content

Conversation

@twoertwein
Copy link
Member

@twoertwein twoertwein commented Jan 30, 2021

xref #39450

This should probably go in 1.2.2.

<1.2.0: engine=c and engine=python handled encoding errors differently when encoding=None (python: "replace", c: "strict"). The engine=c further supported to ignore lines (skiprows) with encoding errors iff encoding=None.

1.2.0 (shared file opening code between engine=c and engine=python): both engine mistakenly used "strict" when encoding=None. engine=c+encoding=None can no longer skip encoding errors.

1.2.1: both engine use "replace" when encoding=None. Both engines can ignore encoding errors in skipped rows iff encoding=None.

Option for 1.3: default to "strict" but expose errors in read_csv (and other read calls that might need it)?

@jreback jreback added Docs IO CSV read_csv, to_csv labels Feb 2, 2021
@jreback jreback added this to the 1.2.2 milestone Feb 2, 2021
@jreback jreback merged commit 2bcd313 into pandas-dev:master Feb 2, 2021
@jreback
Copy link
Contributor

jreback commented Feb 2, 2021

thanks @twoertwein

@lumberbot-app

This comment has been minimized.

@jreback
Copy link
Contributor

jreback commented Feb 2, 2021

@meeseeksdev backport 1.2.x

@lumberbot-app

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs IO CSV read_csv, to_csv

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants