MOVE: describe to pandas/core/describe.py #39102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 11, 2021
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
location suggestion. ping on green.
thanks for just moving.
| @@ -0,0 +1,205 @@ | |||
| """ | |||
| Module responsible for execution of NDFrame.describe() method. | |||
Contributor
There was a problem hiding this comment.
i would put in pandas/core/describe.py
ivanovmg
changed the title
jreback
approved these changes
Jan 11, 2021
Contributor
|
@ivanovmg actually can you merge master again, think i just merged an incompatible change here |
Contributor
|
great ping on green |
Contributor
Author
@jreback, it is green. |
Contributor
|
thanks @ivanovmg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
describefunctionality to a separate module and prepare for the further refactor/simplification (xref #36833).pandas/core/describe.pyNDFrame.describeto functiondescribe_ndframein the new module