Skip to content

Revert "TST: Bare pytest raises" in base extension tests #38748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 28, 2020
Merged

Revert "TST: Bare pytest raises" in base extension tests #38748

merged 3 commits into from
Dec 28, 2020

Conversation

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Dec 28, 2020

Reverts #38576, see discussion there. We should not add detailed error message asserts, as those tests are also used by external packages, that might have different error messages.

@jorisvandenbossche jorisvandenbossche added the Testing pandas testing functions or related to the test suite label Dec 28, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.3 milestone Dec 28, 2020
@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Dec 28, 2020

@MarcoGorelli on the PR you mentioned " ^pandas/tests/extension/ excluded from when the "disallow bare pytest raises" will be applied to CI"; but so I understand it correctly: at the moment we don't yet test it in CI? (it seems "bare_pytest_raises" validation type is not yet used in practice). So this is not yet actionable right now?

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Dec 28, 2020 •
edited
Loading

So this is not yet actionable right now?

Yes, that's right - I was just asking about what should be done in the future about these tests once it is checked in CI.

Also, does pandas/tests/arrays/boolean/test_arithmetic.py need to be reverted too?

@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Dec 28, 2020

I don't have a strong preference. I can also add match=None, whatever you prefer

@jreback jreback merged commit d717eb1 into master Dec 28, 2020
@jreback
Copy link
Contributor

jreback commented Dec 28, 2020

thanks @jorisvandenbossche

@simonjayhawkins simonjayhawkins deleted the revert-38576-bare_pytest_raises branch December 28, 2020 15:35
@jorisvandenbossche jorisvandenbossche mentioned this pull request Dec 30, 2020
Merged
4 tasks
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@jorisvandenbossche @luckyvs1
Revert "TST: Bare pytest raises" in base extension tests (pandas-dev#…
30b92a2 
…38748)

* Revert "TST: Bare pytest raises (pandas-dev#38576)"

This reverts commit 9919623.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Testing pandas testing functions or related to the test suite

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

4 participants

@jorisvandenbossche @MarcoGorelli @jreback