Skip to content

Conversation

@mroeschke
Copy link
Member

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Breaking up the predefined moments_consistency_* functions into more scoped tests with more pytest idioms.

@mroeschke mroeschke added Clean Window rolling, ewma, expanding labels Nov 18, 2020
@mroeschke mroeschke added this to the 1.2 milestone Nov 18, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm merge on green

@mroeschke mroeschke merged commit a022d7b into pandas-dev:master Nov 18, 2020
@mroeschke mroeschke deleted the cln/moments_expanding_consistency branch November 18, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clean Window rolling, ewma, expanding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants