REGR: SeriesGroupBy where index has a tuple name fails #37801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Indexing
Contributor
|
thanks @rhshadrach keem em coming! |
Member
|
@meeseeksdev backport 1.1.x |
This comment has been minimized.
This comment has been minimized.
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Nov 14, 2020
…re index has a tuple name fails
simonjayhawkins
added a commit
that referenced
this pull request
Nov 14, 2020
…as a tuple name fails (#37829) Co-authored-by: Richard Shadrach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThe groupby code that calls
Series.__getitem__catchesKeyErrorandTypeError. If a tuple is fed into anIndexthat is not aMultiIndex, we were raising aValueErrorbutKeyErrorseems more appropriate here and also fixes the regression.While working on this, I found that we raise a
KeyErrorinappropriately if an index of tuples contains duplicates, however this exists back in 1.0.x and so is not part of the regression. I've opened #37800 for this.