Skip to content

TYP: add type annotation to expr.py #36027 #36028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

TYP: add type annotation to expr.py #36027 #36028

wants to merge 1 commit into from

Conversation

@fangchenli
Copy link
Member

@fangchenli fangchenli commented Sep 1, 2020 •
edited
Loading

simonjayhawkins
simonjayhawkins requested changes Sep 1, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VirosaLi for the PR.

This may be fixed in open PR. see #36012 (review)

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Sep 1, 2020
@fangchenli
Copy link
Member Author

fangchenli commented Sep 1, 2020

Thanks @VirosaLi for the PR.

This may be fixed in open PR. see #36012 (review)

Cool, I'll close this one.

@fangchenli fangchenli closed this Sep 1, 2020
@fangchenli fangchenli deleted the type-expr branch September 2, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins requested changes

Assignees

No one assigned

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TYP: add type annotation to expr.py

2 participants

@fangchenli @simonjayhawkins