-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
ENH: GH34946 Check type of names argument to read_csv, read_table…
#34956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I used |
|
Can you add a test for this? I think can go in pandas/tests/io/parser/test_common.py |
|
Will do |
98d7f69 to
0079188
Compare
jreback
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. @gfyoung if you'd have a look.
|
Provided tests pass, lgtm |
…, `read_fwf` to not be a `set`.
Co-authored-by: gfyoung <[email protected]>
6de9af1 to
0ff2e3e
Compare
|
thanks @MJafarMashhadi |
closes BUG: Inconsistent behavior: Occasional crash on same code and data #34946
tests passed
passes
black pandaspasses
git diff upstream/master -u -- "*.py" | flake8 --diffwhatsnew entry
One test failed (TestTSPlot.test_ts_plot_with_tz) but it's not related to what I changed.Does it need a whatsnew entry?