Issue33955 Properly checking whether post_processing is callable or not in Class GroupBy #33988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KenilMehta
commented
May 5, 2020
KenilMehta
commented
- [x ] closes BUG: Not properly checking if post_processing function is callable or not in _get_cythonized_result() function in class GroupBy #33955
…get_cythonized_result() in class GroupBy (pandas-dev#33955)
jreback
requested changes
May 5, 2020
| raise ValueError("'result_is_index' and 'aggregate' cannot both be True!") | ||
| if post_processing: | ||
| if not callable(pre_processing): | ||
| if not callable(post_processing): |
Contributor
There was a problem hiding this comment.
do we have a test that actually hits this?
Member
There was a problem hiding this comment.
#34372 changes the path for GroupBy.std so that this is hit by std tests.
jreback
added
Groupby
Compat
5 tasks
Contributor
|
closing in favor of #34372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.