TST: Making use of tm.external_error_raised

[ShaharNaveh]

• closes #xxxx
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

After #31130 got merged, I can do what I couldn't do here

[WillAyd]

I think this is confusing to say external_error_raised for something in internals

[WillAyd]

Can you alternately not just add the message?

[ShaharNaveh]

I think this is confusing to say external_error_raised for something in internals

@WillAyd I am with you on that, still it's raising an external error message, do you suggest moving it to somewhere else?

[ShaharNaveh]

Can you alternately not just add the message?

@WillAyd I really prefer not to, in #30999 we are fixing all the bare pytest raises, and in order to silent the test case in #30755 we have to pass in the "match" argument, we could just pass in the match=None but as you said here this is not very clear.

[WillAyd]

I don't have a problem with match=None per se - where you linked my comment I was just asking what the purpose of it was

As mentioned I don't think this adds any value and if anything is confusing, but let's see what others think

[WillAyd]

Closing as I don't think this is moving in the right direction, but thanks in any case @MomIsBestFriend !