PERF: improve perf. of Categorical.searchsorted #28795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
added
Performance
gfyoung
reviewed
Oct 5, 2019
doc/source/whatsnew/v1.0.0.rst
Outdated
| - Performance improvement in :meth:`DataFrame.corr` when ``method`` is ``"spearman"`` (:issue:`28139`) | ||
| - Performance improvement in :meth:`DataFrame.replace` when provided a list of values to replace (:issue:`28099`) | ||
| - Performance improvement in :meth:`DataFrame.select_dtypes` by using vectorization instead of iterating over a loop (:issue:`28317`) | ||
| - Performance improvement in :meth:`Categorical.searchsorted` and :meth:`CategoricalIndex.searchsorted` when searching for a single scalar value (:issue:`XXXXX`) |
Member
There was a problem hiding this comment.
Just reference the PR as the issue
topper-123
force-pushed
the
Categorical.searchsorted_II
branch
from
0f46d60 to
27bd6f7
Compare
jreback
approved these changes
Oct 5, 2019
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
lgtm, small comment, ping on green.
|
|
||
| codes = codes[0] if is_scalar(value) else codes | ||
|
|
||
| if is_scalar(value): |
Contributor
There was a problem hiding this comment.
lgtm, i would add a comment here that this is perf sensitive
Contributor
Author
|
Comments addressed. |
topper-123
changed the title
Contributor
|
thanks @topper-123 |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffImproves performance of
Categorical.searchsortedby avoiding expensive data convertions.Also,
CategoricalIndex.searchsortednow callsself.values.searchsorteddirectly instead of going throughalgorithms.searchsorted, which always ends up callingself.values.searchsortedanyway. This ends up getting performance to 5.5 µs instead of 12 µs.