Skip to content

Conversation

@WillAyd
Copy link
Member

@WillAyd WillAyd commented Jun 12, 2019

I must have been a little quick in merging #26802 as it looks like this is causing mypy failures in CI.

Most of these are pretty niche and I think a result of import machinery. Will try to dive deeper later but this should get things green for now

@TomAugspurger TomAugspurger added this to the 0.25.0 milestone Jun 12, 2019
@WillAyd
Copy link
Member Author

WillAyd commented Jun 12, 2019

Annotations might just not be possible here given the dynamic nature. Here's a relevant mypy discussion:

python/mypy#5059

Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about messing the types up.

It looks like azure didn't even run for that last commit. Strange.

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #26820 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26820      +/-   ##
==========================================
- Coverage   91.86%   91.86%   -0.01%     
==========================================
  Files         179      179              
  Lines       50707    50707              
==========================================
- Hits        46583    46580       -3     
- Misses       4124     4127       +3
Flag Coverage Δ
#multiple 90.45% <ø> (ø) ⬆️
#single 41.09% <ø> (-0.1%) ⬇️
Impacted Files Coverage Δ
pandas/io/gcs.py 100% <ø> (ø) ⬆️
pandas/io/s3.py 100% <ø> (ø) ⬆️
pandas/compat/_optional.py 100% <ø> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 634577e...f463aeb. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #26820 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26820      +/-   ##
==========================================
- Coverage   91.86%   91.86%   -0.01%     
==========================================
  Files         179      179              
  Lines       50707    50706       -1     
==========================================
- Hits        46583    46579       -4     
- Misses       4124     4127       +3
Flag Coverage Δ
#multiple 90.45% <ø> (-0.01%) ⬇️
#single 41.12% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gcs.py 100% <ø> (ø) ⬆️
pandas/io/s3.py 100% <ø> (ø) ⬆️
pandas/compat/_optional.py 100% <ø> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 634577e...665f92f. Read the comment docs.

@jreback jreback added the Typing type annotations, mypy/pyright type checking label Jun 12, 2019
@jreback
Copy link
Contributor

jreback commented Jun 12, 2019

lgtm. merge on green.

@WillAyd WillAyd merged commit d66da60 into pandas-dev:master Jun 13, 2019
@WillAyd WillAyd deleted the fix-mypy-failures branch June 13, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants