Skip to content

Conversation

@WillAyd
Copy link
Member

@WillAyd WillAyd commented May 2, 2019

More extension module review / cleanup to get rid of Python2 traces

@WillAyd WillAyd added the Clean label May 2, 2019
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #26266 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26266      +/-   ##
==========================================
- Coverage   91.98%   91.97%   -0.01%     
==========================================
  Files         175      175              
  Lines       52386    52386              
==========================================
- Hits        48185    48181       -4     
- Misses       4201     4205       +4
Flag Coverage Δ
#multiple 90.52% <ø> (ø) ⬆️
#single 40.72% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fafb35...e9dc953. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #26266 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26266      +/-   ##
==========================================
- Coverage   91.98%   91.97%   -0.01%     
==========================================
  Files         175      175              
  Lines       52386    52386              
==========================================
- Hits        48185    48181       -4     
- Misses       4201     4205       +4
Flag Coverage Δ
#multiple 90.52% <ø> (ø) ⬆️
#single 40.72% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fafb35...e9dc953. Read the comment docs.

@jreback jreback added this to the 0.25.0 milestone May 2, 2019
@jreback jreback merged commit d1e4ec3 into pandas-dev:master May 2, 2019
@jreback
Copy link
Contributor

jreback commented May 2, 2019

thanks @WillAyd

@WillAyd WillAyd deleted the py3-move-cleanup branch January 16, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants