Skip to content

BUG/DOC: restrict possibilities for assembly of dates using a DataFrame #12996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

BUG/DOC: restrict possibilities for assembly of dates using a DataFrame #12996

wants to merge 1 commit into from

Conversation

@jreback
Copy link
Contributor

@jreback jreback commented Apr 26, 2016

xref #12967

@jreback jreback added the Datetime Datetime data dtype label Apr 26, 2016
@jreback jreback added this to the 0.18.1 milestone Apr 26, 2016
@jreback
Copy link
Contributor Author

jreback commented Apr 26, 2016

cc @jorisvandenbossche

@jreback
Copy link
Contributor Author

jreback commented Apr 26, 2016

@shoyer

@jreback jreback closed this in db6d009 Apr 26, 2016
jorisvandenbossche
jorisvandenbossche reviewed Apr 26, 2016
View reviewed changes
pandas/tseries/tools.py
99 2000-04-09
Length: 100, dtype: datetime64[ns]
Infer the format from the first entry
Copy link
Member

@jorisvandenbossche jorisvandenbossche Apr 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still a useful example (the usage of infer_datetime_format), but if we keep it, it should just use a string column as input

Copy link
Contributor Author

@jreback jreback Apr 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i'll add that

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Apr 26, 2016

Apart from the doc comment, I would personally even leave out the abbreviations for minutes and seconds. Then also the possible confusion of m as month or minute is avoided (I also never seen 'm' used as abbreviation of minute)

@jreback jreback mentioned this pull request Apr 26, 2016
Closed
@shoyer
Copy link
Member

shoyer commented Apr 27, 2016

+1 for leaving out any abbreviations. I'm not even sure it's actually a
good thing to accept both plural and singular forms.

On Tue, Apr 26, 2016 at 4:07 PM, Joris Van den Bossche <
[email protected]> wrote:

Apart from the doc comment, I would personally even leave out the
abbreviations for minutes and seconds. Then also the possible confusion
of m as month or minute is avoided (I also never seen 'm' used as
abbreviation of minute)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#12996 (comment)

jreback added a commit that referenced this pull request Apr 27, 2016
@jreback
DOC: more pd.to_datetime examples
ec9a399 
closes #13004
xref #12996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Datetime Datetime data dtype

Projects

None yet

Milestone

0.18.1

Development

Successfully merging this pull request may close these issues.

3 participants

@jreback @jorisvandenbossche @shoyer