BUG: value_count(normalize=True, dropna=True) counting missing in denominator, #12558 #12576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickeubank
force-pushed
the
value_count_bug
branch
from
fe3c0f1 to
c348314
Compare
jreback
added
Bug
Missing-data
pandas/core/algorithms.py
Outdated
| if normalize: | ||
| result = result / float(values.size) | ||
| if dropna: | ||
| result = result / float(values[notnull(values)].size) |
jreback
changed the title
Contributor
|
#12566 fixes this too, will need to fix groupby. Lemme know if you wanna work on this and I'll close mine. |
Contributor
Author
|
@kawochen Oops! Sorry, did not mean to double up. If you have this covered I can close -- not sure what you mean about groupby. |
Contributor
|
|
Contributor
Author
|
@kawochen Sounds good! Just let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12558