-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
Add support for math functions in eval() #10953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
looks good. can you add a whatsnew note in 0.17.0 docs. pls squash as well. ping when green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add the issue number here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls move to the Enhancements section
|
once I merged this: #10975 (or you can rebase on top) pls update the tests as you indicated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged the fix for #10952. if you'd add this test, would be great. ping when green.
|
@sklam can you update the tests |
|
@sklam can you update |
|
hmm, it appears |
Add support for math functions in eval()
|
thanks @sklam |
DOC: Update "enhancing perf" doc based on #10953
closes #4893
Extends the eval parser to accept calling math functions.