Simplify interface by using a fallback scenario

- first try new behavior
- if no result return native HDF5 Tables

Author: roberthdevries

pandas/io/pytables.py

@@ -580,35 +580,26 @@ def __enter__(self):
     def __exit__(self, exc_type, exc_value, traceback):
         self.close()
 
-    def keys(self, kind: Optional[str] = "pandas") -> List[str]:
+    def keys(self) -> List[str]:
         """
         Return a list of keys corresponding to objects stored in HDFStore.
-
-        Parameters
-        ----------
-        kind : str, default 'pandas'
-                When kind equals 'pandas' return pandas objects
-                When kind equals 'table' return Table objects
-                Otherwise fail with a ValueError
+        If the store contains pandas native tables, it will return their names.
+        Otherwise the list of names of HDF5 Table objects will be returned.
 
         Returns
         -------
         list
             List of ABSOLUTE path-names (e.g. have the leading '/').
-
-        Raises
-        ------
-        raises ValueError if kind has an illegal value
         """
-        if kind == "pandas":
-            return [n._v_pathname for n in self.groups()]
+        #        if kind == "pandas":
+        objects = [n._v_pathname for n in self.groups()]
+        if objects:
+            return objects
 
-        if kind == "tables":
-            self._check_if_open()
-            return [
-                n._v_pathname for n in self._handle.walk_nodes("/", classname="Table")
-            ]
-        raise ValueError(f"`kind` should be either 'pandas' or 'table' but is [{kind}]")
+        self._check_if_open()
+        return [
+            n._v_pathname for n in self._handle.walk_nodes("/", classname="Table")
+        ]
 
     def __iter__(self):
         return iter(self.keys())

pandas/tests/io/pytables/test_store.py

@@ -299,6 +299,7 @@ def test_keys(self, setup_path):
             assert set(store) == expected
 
     def test_non_pandas_keys(self, setup_path):
+        # GH 29916
         class Table1(tables.IsDescription):
             value1 = tables.Float32Col()
 
@@ -315,10 +316,10 @@ class Table3(tables.IsDescription):
                 h5file.create_table(group, "table2", Table2, "Table 2")
                 h5file.create_table(group, "table3", Table3, "Table 3")
             with HDFStore(path) as store:
-                assert len(store.keys(kind="tables")) == 3
+                assert len(store.keys()) == 3
                 expected = {"/group/table1", "/group/table2", "/group/table3"}
-                assert set(store.keys(kind="tables")) == expected
-                assert set(store.keys(kind="pandas")) == set()
+                assert set(store.keys()) == expected
+                assert set(store) == expected
 
     def test_keys_ignore_hdf_softlink(self, setup_path):