TST: Don't mark all plotting tests as slow (#46003)

Author: mroeschke

ci/run_tests.sh

@@ -30,10 +30,6 @@ if [[ "$PATTERN" ]]; then
   PYTEST_CMD="$PYTEST_CMD -m \"$PATTERN\""
 fi
 
-if [[ $(uname) != "Linux"  && $(uname) != "Darwin" ]]; then
-    PYTEST_CMD="$PYTEST_CMD --ignore=pandas/tests/plotting/"
-fi
-
 echo $PYTEST_CMD
 sh -c "$PYTEST_CMD"
 

pandas/plotting/_core.py

@@ -1793,12 +1793,19 @@ def _load_backend(backend: str) -> types.ModuleType:
     found_backend = False
 
     eps = entry_points()
-    if "pandas_plotting_backends" in eps:
-        for entry_point in eps["pandas_plotting_backends"]:
-            found_backend = entry_point.name == backend
-            if found_backend:
-                module = entry_point.load()
-                break
+    key = "pandas_plotting_backends"
+    # entry_points lost dict API ~ PY 3.10
+    # https://github.com/python/importlib_metadata/issues/298
+    if hasattr(eps, "select"):
+        # error: "Dict[str, Tuple[EntryPoint, ...]]" has no attribute "select"
+        entry = eps.select(group=key)  # type: ignore[attr-defined]
+    else:
+        entry = eps.get(key, ())
+    for entry_point in entry:
+        found_backend = entry_point.name == backend
+        if found_backend:
+            module = entry_point.load()
+            break
 
     if not found_backend:
         # Fall back to unregistered, module name approach.

pandas/tests/plotting/common.py

@@ -1,8 +1,5 @@
 """
 Module consolidating common testing functions for checking plotting.
-
-Currently all plotting tests are marked as slow via
-``pytestmark = pytest.mark.slow`` at the module level.
 """
 
 from __future__ import annotations

pandas/tests/plotting/frame/test_frame.py

@@ -33,11 +33,10 @@
 from pandas.io.formats.printing import pprint_thing
 import pandas.plotting as plotting
 
-pytestmark = pytest.mark.slow
-
 
 @td.skip_if_no_mpl
 class TestDataFramePlots(TestPlotBase):
+    @pytest.mark.slow
     def test_plot(self):
         df = tm.makeTimeDataFrame()
         _check_plot_works(df.plot, grid=False)
@@ -163,6 +162,7 @@ def test_nullable_int_plot(self):
         _check_plot_works(df[["A", "D"]].plot, x="A", y="D")
         _check_plot_works(df[["A", "E"]].plot, x="A", y="E")
 
+    @pytest.mark.slow
     def test_integer_array_plot(self):
         # GH 25587
         arr = pd.array([1, 2, 3, 4], dtype="UInt32")
@@ -787,6 +787,7 @@ def test_plot_scatter_with_s(self):
         ax = df.plot.scatter(x="a", y="b", s="c")
         tm.assert_numpy_array_equal(df["c"].values, right=ax.collections[0].get_sizes())
 
+    @pytest.mark.slow
     def test_plot_bar(self):
         df = DataFrame(
             np.random.randn(6, 4),
@@ -1416,6 +1417,7 @@ def test_pie_df_nan(self):
             expected_labels = base_expected[:i] + base_expected[i + 1 :]
             assert result_labels == expected_labels
 
+    @pytest.mark.slow
     def test_errorbar_plot(self):
         d = {"x": np.arange(12), "y": np.arange(12, 0, -1)}
         df = DataFrame(d)
@@ -1462,6 +1464,7 @@ def test_errorbar_plot(self):
         with tm.external_error_raised(TypeError):
             df.plot(yerr=df_err)
 
+    @pytest.mark.slow
     @pytest.mark.parametrize("kind", ["line", "bar", "barh"])
     def test_errorbar_plot_different_kinds(self, kind):
         d = {"x": np.arange(12), "y": np.arange(12, 0, -1)}
@@ -1513,6 +1516,7 @@ def test_errorbar_with_integer_column_names(self):
         ax = _check_plot_works(df.plot, y=0, yerr=1)
         self._check_has_errorbars(ax, xerr=0, yerr=1)
 
+    @pytest.mark.slow
     def test_errorbar_with_partial_columns(self):
         df = DataFrame(np.random.randn(10, 3))
         df_err = DataFrame(np.random.randn(10, 2), columns=[0, 2])

pandas/tests/plotting/frame/test_frame_color.py

@@ -15,8 +15,6 @@
     _check_plot_works,
 )
 
-pytestmark = pytest.mark.slow
-
 
 @td.skip_if_no_mpl
 class TestDataFrameColor(TestPlotBase):

pandas/tests/plotting/frame/test_frame_groupby.py

@@ -7,8 +7,6 @@
 from pandas import DataFrame
 from pandas.tests.plotting.common import TestPlotBase
 
-pytestmark = pytest.mark.slow
-
 
 @td.skip_if_no_mpl
 class TestDataFramePlotsGroupby(TestPlotBase):

pandas/tests/plotting/frame/test_frame_legend.py

@@ -1,14 +1,14 @@
 import numpy as np
 import pytest
 
+import pandas.util._test_decorators as td
+
 from pandas import (
     DataFrame,
     date_range,
 )
 from pandas.tests.plotting.common import TestPlotBase
 
-pytestmark = pytest.mark.slow
-
 
 class TestFrameLegend(TestPlotBase):
     @pytest.mark.xfail(
@@ -45,6 +45,7 @@ def test_legend_false(self):
         expected = ["blue", "green", "red"]
         assert result == expected
 
+    @td.skip_if_no_scipy
     def test_df_legend_labels(self):
         kinds = ["line", "bar", "barh", "kde", "area", "hist"]
         df = DataFrame(np.random.rand(3, 3), columns=["a", "b", "c"])
@@ -158,13 +159,21 @@ def test_legend_name(self):
         leg_title = ax.legend_.get_title()
         self._check_text_labels(leg_title, "new")
 
-    def test_no_legend(self):
-        kinds = ["line", "bar", "barh", "kde", "area", "hist"]
+    @pytest.mark.parametrize(
+        "kind",
+        [
+            "line",
+            "bar",
+            "barh",
+            pytest.param("kde", marks=td.skip_if_no_scipy),
+            "area",
+            "hist",
+        ],
+    )
+    def test_no_legend(self, kind):
         df = DataFrame(np.random.rand(3, 3), columns=["a", "b", "c"])
-
-        for kind in kinds:
-            ax = df.plot(kind=kind, legend=False)
-            self._check_legend_labels(ax, visible=False)
+        ax = df.plot(kind=kind, legend=False)
+        self._check_legend_labels(ax, visible=False)
 
     def test_missing_markers_legend(self):
         # 14958

pandas/tests/plotting/frame/test_frame_subplots.py

@@ -19,11 +19,10 @@
 
 from pandas.io.formats.printing import pprint_thing
 
-pytestmark = pytest.mark.slow
-
 
 @td.skip_if_no_mpl
 class TestDataFramePlotsSubplots(TestPlotBase):
+    @pytest.mark.slow
     def test_subplots(self):
         df = DataFrame(np.random.rand(10, 3), index=list(string.ascii_letters[:10]))
 
@@ -237,6 +236,7 @@ def test_subplots_layout_single_column(
         )
         assert axes.shape == expected_shape
 
+    @pytest.mark.slow
     def test_subplots_warnings(self):
         # GH 9464
         with tm.assert_produces_warning(None):
@@ -580,19 +580,21 @@ def test_bar_barwidth_position(self, kwargs):
         df = DataFrame(np.random.randn(5, 5))
         self._check_bar_alignment(df, width=0.9, position=0.2, **kwargs)
 
-    def test_bar_barwidth_position_int(self):
+    @pytest.mark.parametrize("w", [1, 1.0])
+    def test_bar_barwidth_position_int(self, w):
+        # GH 12979
+        df = DataFrame(np.random.randn(5, 5))
+        ax = df.plot.bar(stacked=True, width=w)
+        ticks = ax.xaxis.get_ticklocs()
+        tm.assert_numpy_array_equal(ticks, np.array([0, 1, 2, 3, 4]))
+        assert ax.get_xlim() == (-0.75, 4.75)
+        # check left-edge of bars
+        assert ax.patches[0].get_x() == -0.5
+        assert ax.patches[-1].get_x() == 3.5
+
+    def test_bar_barwidth_position_int_width_1(self):
         # GH 12979
         df = DataFrame(np.random.randn(5, 5))
-
-        for w in [1, 1.0]:
-            ax = df.plot.bar(stacked=True, width=w)
-            ticks = ax.xaxis.get_ticklocs()
-            tm.assert_numpy_array_equal(ticks, np.array([0, 1, 2, 3, 4]))
-            assert ax.get_xlim() == (-0.75, 4.75)
-            # check left-edge of bars
-            assert ax.patches[0].get_x() == -0.5
-            assert ax.patches[-1].get_x() == 3.5
-
         self._check_bar_alignment(df, kind="bar", stacked=True, width=1)
         self._check_bar_alignment(df, kind="barh", stacked=False, width=1)
         self._check_bar_alignment(df, kind="barh", stacked=True, width=1)

pandas/tests/plotting/frame/test_hist_box_by.py

@@ -24,6 +24,7 @@ def hist_df():
 
 @td.skip_if_no_mpl
 class TestHistWithBy(TestPlotBase):
+    @pytest.mark.slow
     @pytest.mark.parametrize(
         "by, column, titles, legends",
         [

pandas/tests/plotting/test_backend.py

@@ -12,9 +12,6 @@
 setattr(dummy_backend, "plot", lambda *args, **kwargs: "used_dummy")
 
 
-pytestmark = pytest.mark.slow
-
-
 @pytest.fixture
 def restore_backend():
     """Restore the plotting backend to matplotlib"""