temporarily dont check stacklevel in _check_plot_works

Author: MarcoGorelli

.pre-commit-config.yaml

@@ -147,12 +147,6 @@ repos:
             # Check for deprecated messages without sphinx directive
             |(DEPRECATED|DEPRECATE|Deprecated)(:|,|\.)
         types_or: [python, cython, rst]
-    -   id: stacklevel
-        name: Use find_stack_level instead of setting stacklevel manually
-        language: pygrep
-        entry: 'stacklevel=\d+'
-        types_or: [python, cython, rst]
-        exclude: pandas/__init__\.py
     -   id: cython-casting
         name: Check Cython casting is `<type>obj`, not `<type> obj`
         language: pygrep

pandas/compat/pickle_compat.py

@@ -5,7 +5,6 @@
 
 import contextlib
 import copy
-import inspect
 import io
 import pickle as pkl
 from typing import (
@@ -18,7 +17,6 @@
 
 from pandas._libs.arrays import NDArrayBacked
 from pandas._libs.tslibs import BaseOffset
-from pandas.util._exceptions import find_stack_level
 
 from pandas import Index
 from pandas.core.arrays import (
@@ -89,7 +87,7 @@ def __new__(cls) -> Series:  # type: ignore[misc]
         warnings.warn(
             _sparse_msg.format(cls="SparseSeries", new="Series"),
             FutureWarning,
-            stacklevel=find_stack_level(inspect.currentframe()),
+            stacklevel=6,
         )
 
         return Series(dtype=object)
@@ -107,7 +105,7 @@ def __new__(cls) -> DataFrame:  # type: ignore[misc]
         warnings.warn(
             _sparse_msg.format(cls="SparseDataFrame", new="DataFrame"),
             FutureWarning,
-            stacklevel=find_stack_level(inspect.currentframe()),
+            stacklevel=6,
         )
 
         return DataFrame()

pandas/core/internals/__init__.py

@@ -1,5 +1,3 @@
-import inspect
-
 from pandas.core.internals.api import make_block
 from pandas.core.internals.array_manager import (
     ArrayManager,
@@ -43,6 +41,7 @@
 
 
 def __getattr__(name: str):
+    import inspect
     import warnings
 
     from pandas.util._exceptions import find_stack_level

pandas/tests/indexes/test_common.py

@@ -406,6 +406,7 @@ def test_astype_preserves_name(self, index, dtype):
             with tm.assert_produces_warning(
                 warn,
                 raise_on_extra_warnings=is_pyarrow_str,
+                check_stacklevel=False,
             ):
                 result = index.astype(dtype)
         except (ValueError, TypeError, NotImplementedError, SystemError):

pandas/tests/io/parser/test_dialect.py

@@ -146,6 +146,11 @@ def test_dialect_conflict_delimiter(all_parsers, custom_dialect, kwargs, warning
     data = "a:b\n1:2"
 
     with tm.with_csv_dialect(dialect_name, **dialect_kwargs):
-        with tm.assert_produces_warning(warning_klass):
-            result = parser.read_csv(StringIO(data), dialect=dialect_name, **kwargs)
-            tm.assert_frame_equal(result, expected)
+        result = parser.read_csv_check_warnings(
+            warning_klass,
+            "Conflicting values for 'delimiter'",
+            StringIO(data),
+            dialect=dialect_name,
+            **kwargs,
+        )
+        tm.assert_frame_equal(result, expected)

pandas/tests/io/parser/test_python_parser_only.py

@@ -424,8 +424,9 @@ def test_on_bad_lines_callable_not_expected_length(python_parser_only):
 """
     bad_sio = StringIO(data)
 
-    with tm.assert_produces_warning(ParserWarning, match="Length of header or names"):
-        result = parser.read_csv(bad_sio, on_bad_lines=lambda x: x)
+    result = parser.read_csv_check_warnings(
+        ParserWarning, "Length of header or names", bad_sio, on_bad_lines=lambda x: x
+    )
     expected = DataFrame({"a": [1, 2, 3], "b": [2, 3, 4]})
     tm.assert_frame_equal(result, expected)
 

pandas/tests/plotting/frame/test_hist_box_by.py

@@ -164,7 +164,7 @@ def test_hist_plot_empty_list_string_tuple_by(self, by, column, hist_df):
     def test_hist_plot_layout_with_by(self, by, column, layout, axes_num, hist_df):
         # GH 15079
         # _check_plot_works adds an ax so catch warning. see GH #13188
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             axes = _check_plot_works(
                 hist_df.plot.hist, column=column, by=by, layout=layout
             )

pandas/tests/plotting/test_boxplot_method.py

@@ -77,7 +77,7 @@ def test_boxplot_legacy2(self):
         df = DataFrame(np.random.rand(10, 2), columns=["Col1", "Col2"])
         df["X"] = Series(["A", "A", "A", "A", "A", "B", "B", "B", "B", "B"])
         df["Y"] = Series(["A"] * 10)
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             _check_plot_works(df.boxplot, by="X")
 
         # When ax is supplied and required number of axes is 1,

pandas/tests/plotting/test_hist_method.py

@@ -31,9 +31,9 @@ def test_hist_legacy(self, ts):
         _check_plot_works(ts.hist, grid=False)
         _check_plot_works(ts.hist, figsize=(8, 10))
         # _check_plot_works adds an ax so catch warning. see GH #13188
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             _check_plot_works(ts.hist, by=ts.index.month)
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             _check_plot_works(ts.hist, by=ts.index.month, bins=5)
 
         fig, ax = self.plt.subplots(1, 1)
@@ -74,31 +74,31 @@ def test_hist_layout_with_by(self, hist_df):
         # _check_plot_works adds an `ax` kwarg to the method call
         # so we get a warning about an axis being cleared, even
         # though we don't explicing pass one, see GH #13188
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             axes = _check_plot_works(df.height.hist, by=df.gender, layout=(2, 1))
         self._check_axes_shape(axes, axes_num=2, layout=(2, 1))
 
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             axes = _check_plot_works(df.height.hist, by=df.gender, layout=(3, -1))
         self._check_axes_shape(axes, axes_num=2, layout=(3, 1))
 
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             axes = _check_plot_works(df.height.hist, by=df.category, layout=(4, 1))
         self._check_axes_shape(axes, axes_num=4, layout=(4, 1))
 
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             axes = _check_plot_works(df.height.hist, by=df.category, layout=(2, -1))
         self._check_axes_shape(axes, axes_num=4, layout=(2, 2))
 
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             axes = _check_plot_works(df.height.hist, by=df.category, layout=(3, -1))
         self._check_axes_shape(axes, axes_num=4, layout=(3, 2))
 
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             axes = _check_plot_works(df.height.hist, by=df.category, layout=(-1, 4))
         self._check_axes_shape(axes, axes_num=4, layout=(1, 4))
 
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             axes = _check_plot_works(df.height.hist, by=df.classroom, layout=(2, 2))
         self._check_axes_shape(axes, axes_num=3, layout=(2, 2))
 
@@ -235,7 +235,7 @@ class TestDataFramePlots(TestPlotBase):
     def test_hist_df_legacy(self, hist_df):
         from matplotlib.patches import Rectangle
 
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             _check_plot_works(hist_df.hist)
 
         # make sure layout is handled
@@ -248,7 +248,7 @@ def test_hist_df_legacy(self, hist_df):
                 dtype=np.int64,
             )
         )
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             axes = _check_plot_works(df.hist, grid=False)
         self._check_axes_shape(axes, axes_num=3, layout=(2, 2))
         assert not axes[1, 1].get_visible()
@@ -267,20 +267,20 @@ def test_hist_df_legacy(self, hist_df):
                 dtype=np.int64,
             )
         )
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             axes = _check_plot_works(df.hist, layout=(4, 2))
         self._check_axes_shape(axes, axes_num=6, layout=(4, 2))
 
         # make sure sharex, sharey is handled
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             _check_plot_works(df.hist, sharex=True, sharey=True)
 
         # handle figsize arg
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             _check_plot_works(df.hist, figsize=(8, 10))
 
         # check bins argument
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             _check_plot_works(df.hist, bins=5)
 
         # make sure xlabelsize and xrot are handled
@@ -659,13 +659,13 @@ def test_grouped_hist_layout(self, hist_df):
         with pytest.raises(ValueError, match=msg):
             df.hist(column="height", by=df.category, layout=(-1, -1))
 
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             axes = _check_plot_works(
                 df.hist, column="height", by=df.gender, layout=(2, 1)
             )
         self._check_axes_shape(axes, axes_num=2, layout=(2, 1))
 
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             axes = _check_plot_works(
                 df.hist, column="height", by=df.gender, layout=(2, -1)
             )
@@ -682,14 +682,14 @@ def test_grouped_hist_layout(self, hist_df):
         tm.close()
 
         # GH 6769
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             axes = _check_plot_works(
                 df.hist, column="height", by="classroom", layout=(2, 2)
             )
         self._check_axes_shape(axes, axes_num=3, layout=(2, 2))
 
         # without column
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             axes = _check_plot_works(df.hist, by="classroom")
         self._check_axes_shape(axes, axes_num=3, layout=(2, 2))
 

pandas/tests/plotting/test_misc.py

@@ -125,7 +125,7 @@ def test_scatter_matrix_axis(self, pass_axis):
         df[0] = (df[0] - 2) / 3
 
         # we are plotting multiples on a sub-plot
-        with tm.assert_produces_warning(UserWarning):
+        with tm.assert_produces_warning(UserWarning, check_stacklevel=False):
             axes = _check_plot_works(
                 scatter_matrix,
                 filterwarnings="always",