Make it tables < 3.4.3 friendly

Author: rbenes

pandas/io/pytables.py

@@ -984,7 +984,7 @@ def put(
         data_columns: Optional[List[str]] = None,
         encoding=None,
         errors: str = "strict",
-        track_times: bool = True,
+        track_times: Optional[bool] = None,
     ):
         """
         Store object in HDFStore.
@@ -1630,7 +1630,7 @@ def _write_to_group(
         data_columns=None,
         encoding=None,
         errors: str = "strict",
-        track_times: bool = True,
+        track_times: Optional[bool] = None,
     ):
         group = self.get_node(key)
 
@@ -4113,7 +4113,7 @@ def write(
         dropna=False,
         nan_rep=None,
         data_columns=None,
-        track_times=True,
+        track_times=None,
     ):
 
         if not append and self.is_exists:
@@ -4145,8 +4145,18 @@ def write(
             # set the table attributes
             table.set_attrs()
 
+            if track_times is not None:
+                from tables import __version__ as tables_version
+
+                if tables_version >= "3.4.3":
+                    options["track_times"] = track_times
+                else:
+                    raise ValueError(
+                        "You cannot set track_times with table version < 3.4.3"
+                    )
+
             # create the table
-            table._handle.create_table(table.group, track_times=track_times, **options)
+            table._handle.create_table(table.group, **options)
 
         # update my info
         table.attrs.info = table.info

pandas/tests/io/pytables/test_store.py

@@ -303,6 +303,7 @@ def test_no_track_times(self, setup_path):
 
         import hashlib
         import time
+        import tables
 
         def checksum(filename, hash_factory=hashlib.md5, chunk_num_blocks=128):
             h = hash_factory()
@@ -315,32 +316,39 @@ def create_h5_and_return_checksum(track_times):
             with ensure_clean_path(setup_path) as path:
                 df = pd.DataFrame({"a": [1]})
 
-                hdf = pd.HDFStore(path, mode="w")
-                hdf.put(
-                    "table",
-                    df,
-                    format="table",
-                    data_columns=True,
-                    index=None,
-                    track_times=track_times,
-                )
-                hdf.close()
+                with pd.HDFStore(path, mode="w") as hdf:
+                    hdf.put(
+                        "table",
+                        df,
+                        format="table",
+                        data_columns=True,
+                        index=None,
+                        track_times=track_times,
+                    )
+
                 return checksum(path)
 
-        checksum_0_tt_false = create_h5_and_return_checksum(track_times=False)
-        checksum_0_tt_true = create_h5_and_return_checksum(track_times=True)
+        if tables.__version__ < "3.4.3":
+            with pytest.raises(
+                ValueError,
+                match="You cannot set track_times with table version < 3.4.3",
+            ):
+                create_h5_and_return_checksum(track_times=False)
+        else:
+            checksum_0_tt_false = create_h5_and_return_checksum(track_times=False)
+            checksum_0_tt_true = create_h5_and_return_checksum(track_times=True)
 
-        # sleep is necessary to create h5 with different creation time
-        time.sleep(1)
+            # sleep is necessary to create h5 with different creation time
+            time.sleep(1)
 
-        checksum_1_tt_false = create_h5_and_return_checksum(track_times=False)
-        checksum_1_tt_true = create_h5_and_return_checksum(track_times=True)
+            checksum_1_tt_false = create_h5_and_return_checksum(track_times=False)
+            checksum_1_tt_true = create_h5_and_return_checksum(track_times=True)
 
-        # checksums are the same if track_time = False
-        assert checksum_0_tt_false == checksum_1_tt_false
+            # checksums are the same if track_time = False
+            assert checksum_0_tt_false == checksum_1_tt_false
 
-        # checksums are NOT same if track_time = True
-        assert checksum_0_tt_true != checksum_1_tt_true
+            # checksums are NOT same if track_time = True
+            assert checksum_0_tt_true != checksum_1_tt_true
 
     def test_keys_ignore_hdf_softlink(self, setup_path):