Skip to content

Upgrade pyright to 1.1.343 #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 26, 2023
Merged

Upgrade pyright to 1.1.343 #845

merged 1 commit into from
Dec 26, 2023

Conversation

@paw-lu
Copy link
Contributor

@paw-lu paw-lu commented Dec 26, 2023

  • Closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added: Please use assert_type() to assert the type of any return value

Pin pyright to 1.1.343. Unblocks #823 by including change introduced in:

Dr-Irv
Dr-Irv approved these changes Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @paw-lu

@Dr-Irv Dr-Irv merged commit 888c3cc into pandas-dev:main Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paw-lu @Dr-Irv