-
Notifications
You must be signed in to change notification settings - Fork 286
Add support for renaming with Jedi #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your interest in palantir/python-language-server, @fsouza! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
|
Oh I see that the upgrade to jedi 0.17.0 is being handled in #781. I can rebase my changes once that's merged. |
Will go back to upstream once palantir/python-language-server#801 (or some alternative) is merged.
I think so too. Please use 3.6 instead of 3.5 in our CIs. |
ccordoba12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @fsouza! I left some small comments for you (please try to address them asap, so we can include your work in our next version).
|
Hi @ccordoba12, thanks for the feedback. I'll be able to address it later today or tomorrow morning (EDT). No need to hold the release if that doesn't work for you. Thank you! :D |
Since jedi refactoring requires Python 3.6+, let's make sure we test it.
If you can do it between today and tomorrow is fine. We still have to review and merge PR #754, which we plan to do tomorrow. |
|
@ccordoba12 I think I got it all. Thanks for all the feedback! |
ccordoba12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fsouza for addressing our review so quickly! I just left a minor suggestion, otherwise looks good.
Co-authored-by: Carlos Cordoba <[email protected]>
|
Don't worry about the failures in our tests. They are due to a new flake8 version. |
ccordoba12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fsouza!
Leverages jedi's support for refactoring to implement rename.
This requires upgrading jedi.
I can split this PR in two if preferred (first upgrade jedi, then add rename).Nevermind I see that #781 exists, once that's merged I can rebase.Note: Jedi refactoring requires Python 3.6+, so I added 3.6 to CI. I didn't remove Python 3.5, but I believe at this point it's probably safe to do so. Thoughts? Also let me know if you'd rather go all the way to Python 3.8.
Closes #530.