Skip to content

Conversation

@bnavigator
Copy link
Contributor

Hello,

def test_references_builtin(tmp_workspace): # pylint: disable=redefined-outer-name
# Over 'UnicodeError':
position = {'line': 4, 'character': 7}
doc2_uri = uris.from_fs_path(os.path.join(tmp_workspace.root_path, DOC2_NAME))
doc2 = Document(doc2_uri)
refs = pyls_references(doc2, position)
assert len(refs) == 1

Does len(refs) need to be exactly 1 here? On my system, the test fails because there are quite a few more references found.

@bnavigator bnavigator changed the title fix references test PR: Allow more references returned in test_references_builtin Apr 10, 2020
@goanpeca
Copy link
Contributor

@dalthviz @andfoy ?

@ccordoba12
Copy link
Contributor

Does len(refs) need to be exactly 1 here? On my system, the test fails because there are quite a few more references found.

That's a new feature of Jedi 0.16+. I think there's no harm in merging this one.

@ccordoba12 ccordoba12 changed the title PR: Allow more references returned in test_references_builtin Allow more references returned in test_references_builtin Apr 12, 2020
@ccordoba12 ccordoba12 merged commit 1967c4f into palantir:develop Apr 12, 2020
@bnavigator
Copy link
Contributor Author

bnavigator commented Apr 12, 2020

Thank you! Yes it indeed came up while working on #744 / PR dalthviz#1 to #775

@dalthviz
Copy link
Contributor

@ccordoba12 should I merge the proposed changes in dalthviz#1 made by @bnavigator ? (To rerun the CI test suite with the things that @bnavigator worked).

@ccordoba12
Copy link
Contributor

@dalthviz, I left some comments for @bnavigator in that PR.

@ccordoba12 ccordoba12 added this to the 0.31.10 milestone Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants