Fix hover request for numpy alias (np) and ufuncs #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
force-pushed
the
numpy_hover
branch
2 times, most recently
from
a326507 to
51fe88c
Compare
sthagen
added a commit
to sthagen/palantir-python-language-server
that referenced
this pull request
Apr 4, 2020
PR: Fix hover request for numpy alias (np) and ufuncs (palantir#768)
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @ccordoba12 we noticed that hover requests were not working for
npor NumPy ufuncs likenp.sinsince the validation of definitions withx.name == wordfails. For example:name -> numpyvsword -> npname -> ufuncvsword -> sin)This PR proposes to not do the validation mentioned in case only one definition is returned by Jedi, and take that unique definition to respond the hover request.