Team: DELETE Requests should return empty response, consistent with the rest of SDK

Author: zanbaldwin

src/Api/Teams.php

@@ -50,23 +50,19 @@ public function edit($teamId, string $name, TeamPermissions $permissions): array
         return $this->put(sprintf('/teams/%s/', $teamId), $parameters);
     }
 
-    public function remove($teamId): bool
+    public function remove($teamId): array
     {
-        // Returns empty response on success.
-        $this->delete(sprintf('/teams/%s/', $teamId));
-        return true;
+        return $this->delete(sprintf('/teams/%s/', $teamId));
     }
 
     public function addMember($teamId, $userId): array
     {
         return $this->put(sprintf('/teams/%s/members/%s/', $teamId, $userId));
     }
 
-    public function removeMember($teamId, $userId): bool
+    public function removeMember($teamId, $userId): array
     {
-        // Returns empty response on success.
-        $this->delete(sprintf('/teams/%s/members/%s/', $teamId, $userId));
-        return true;
+        return $this->delete(sprintf('/teams/%s/members/%s/', $teamId, $userId));
     }
 
     public function packages($teamId)

tests/Api/TeamsTest.php

@@ -168,15 +168,16 @@ public function testEditTeam(): void
 
     public function testDeleteTeam(): void
     {
+        $expected = [];
+
         /** @var Teams&MockObject $api */
         $api = $this->getApiMock();
         $api->expects($this->once())
             ->method('delete')
             ->with($this->equalTo('/teams/1/'))
-            // Will return empty response.
-            ->willReturn([]);
+            ->willReturn($expected);
 
-        $this->assertSame(true, $api->remove(1));
+        $this->assertSame($expected, $api->remove(1));
     }
 
     public function testAddMember(): void
@@ -204,15 +205,16 @@ public function testAddMember(): void
 
     public function removeMember(): void
     {
+        $expected = [];
+
         /** @var Teams&MockObject $api */
         $api = $this->getApiMock();
         $api->expects($this->once())
             ->method('delete')
             ->with($this->equalTo('/teams/1/members/12/'))
-            // Will return empty response.
-            ->willReturn([]);
+            ->willReturn($expected);
 
-        $this->assertSame(true, $api->removeMember(1, 12));
+        $this->assertSame($expected, $api->removeMember(1, 12));
     }
 
     /**