Team: Add Type-honts and Update Tests

Author: zanbaldwin

src/Api/Teams.php

@@ -18,7 +18,7 @@ public function all()
         return $this->get('/teams/');
     }
 
-    public function create($name, TeamPermissions $permissions)
+    public function create(string $name, TeamPermissions $permissions): array
     {
         $parameters = [
             'name' => $name,
@@ -34,7 +34,7 @@ public function create($name, TeamPermissions $permissions)
         return $this->post('/teams/', $parameters);
     }
 
-    public function edit($teamId, $name, TeamPermissions $permissions)
+    public function edit($teamId, string $name, TeamPermissions $permissions): array
     {
         $parameters = [
             'name' => $name,
@@ -50,19 +50,23 @@ public function edit($teamId, $name, TeamPermissions $permissions)
         return $this->put(sprintf('/teams/%s/', $teamId), $parameters);
     }
 
-    public function remove($teamId)
+    public function remove($teamId): bool
     {
-        return $this->delete(sprintf('/teams/%s/', $teamId));
+        // Returns empty response on success.
+        $this->delete(sprintf('/teams/%s/', $teamId));
+        return true;
     }
 
-    public function addMember($teamId, $userId)
+    public function addMember($teamId, $userId): array
     {
         return $this->put(sprintf('/teams/%s/members/%s/', $teamId, $userId));
     }
 
-    public function removeMember($teamId, $userId)
+    public function removeMember($teamId, $userId): bool
     {
-        return $this->delete(sprintf('/teams/%s/members/%s/', $teamId, $userId));
+        // Returns empty response on success.
+        $this->delete(sprintf('/teams/%s/members/%s/', $teamId, $userId));
+        return true;
     }
 
     public function packages($teamId)

tests/Api/TeamsTest.php

@@ -94,7 +94,7 @@ public function testRemovePackage()
         $this->assertSame($expected, $api->removePackage(1, 'acme-website/package'));
     }
 
-    public function testCreateTeam()
+    public function testCreateTeam(): void
     {
         $expected = [
             [
@@ -132,11 +132,11 @@ public function testCreateTeam()
         $this->assertSame($expected, $api->create('New Team', $permissions));
     }
 
-    public function testEditTeam()
+    public function testEditTeam(): void
     {
         $expected = [
             [
-                'id' => 1,
+                'id' => 123,
                 'name' => 'New Team',
                 'permissions' => [
                     'canEditTeamPackages' => true,
@@ -170,21 +170,20 @@ public function testEditTeam()
         $this->assertSame($expected, $api->edit(123, 'New Team', $permissions));
     }
 
-    public function testDeleteTeam()
+    public function testDeleteTeam(): void
     {
-        $expected = null;
-
         /** @var Teams&MockObject $api */
         $api = $this->getApiMock();
         $api->expects($this->once())
             ->method('delete')
             ->with($this->equalTo('/teams/1/'))
-            ->willReturn($expected);
+            // Will return empty response.
+            ->willReturn([]);
 
-        $this->assertSame($expected, $api->remove(1));
+        $this->assertSame(true, $api->remove(1));
     }
 
-    public function testAddMember()
+    public function testAddMember(): void
     {
         $expected = [
             [
@@ -212,27 +211,17 @@ public function testAddMember()
         $this->assertSame($expected, $api->addMember(1, 12));
     }
 
-    public function removeMember()
+    public function removeMember(): void
     {
-        $expected = [
-            [
-                'id' => 1,
-                'name' => 'New Team',
-                'permission' => 'view',
-                'members' => [],
-                'projects' => [
-                ],
-            ]
-        ];
-
         /** @var Teams&MockObject $api */
         $api = $this->getApiMock();
         $api->expects($this->once())
             ->method('delete')
             ->with($this->equalTo('/teams/1/members/12/'))
-            ->willReturn($expected);
+            // Will return empty response.
+            ->willReturn([]);
 
-        $this->assertSame($expected, $api->removeMember(1, 12));
+        $this->assertSame(true, $api->removeMember(1, 12));
     }
 
     /**