set_target_release: Fail if setting target release to a pruned TUF repo #9117
Conversation
| // Attempt to make repo2 the target release. This should fail with a | ||
| // reasonable error message (it's been pruned). | ||
| let err = datastore | ||
| .target_release_insert( |
There was a problem hiding this comment.
target_release_insert a UUID that does not exist?
Would it still claim to be pruned?
| let result = insert_into(dsl::target_release) | ||
| .values(selection) | ||
| .returning(TargetRelease::as_returning()) | ||
| .get_result_async(&*conn) | ||
| .await | ||
| .optional() | ||
| .map_err(|e| { | ||
| public_error_from_diesel(e, ErrorHandler::Server) | ||
| })?; |
There was a problem hiding this comment.
This is probably the same as it was before, but does this do something reasonable if the INSERT fails for some other reason (like the generation number was already inserted)?
There was a problem hiding this comment.
Yeah, I added a test for exactly that case, which still causes the insertion to fail with the same error it did before. The .optional() here only lets us handle "insert succeeded but returned 0 rows", which I believe can only be caused by the repo being pruned (the error we expect) or we got passed a UUID that isn't in the tuf_repo table at all (which would be a mistake somewhere else, and would only result in us claiming that the nonexistent repo was pruned instead of more clearly saying it doesn't exist).
Fixes #9114.