self-review fixes

Author: david-crespo

nexus/db-queries/src/db/datastore/update.rs

@@ -36,7 +36,7 @@ use uuid::Uuid;
 
 /// The return value of [`DataStore::tuf_repo_insert`].
 ///
-/// This is similar to [`external::TufRepoInsertResponse`], but uses
+/// This is similar to [`views::TufRepoUpload`], but uses
 /// nexus-db-model's types instead of external types.
 pub struct TufRepoInsertResponse {
     pub recorded: TufRepoDescription,
@@ -204,7 +204,7 @@ impl DataStore {
     }
 
     /// List all TUF repositories (without artifacts) ordered by system version (newest first by default).
-    pub async fn tuf_repo_list_no_artifacts(
+    pub async fn tuf_repo_list(
         &self,
         opctx: &OpContext,
         pagparams: &DataPageParams<'_, Version>,

nexus/src/app/update.rs

@@ -95,22 +95,18 @@ impl super::Nexus {
         &self,
         opctx: &OpContext,
         system_version: Version,
-    ) -> Result<nexus_db_model::TufRepo, HttpError> {
+    ) -> Result<nexus_db_model::TufRepo, Error> {
         self.db_datastore
             .tuf_repo_get_by_version(opctx, system_version.into())
             .await
-            .map_err(HttpError::from)
     }
 
     pub(crate) async fn updates_list_repositories(
         &self,
         opctx: &OpContext,
         pagparams: &DataPageParams<'_, Version>,
-    ) -> Result<Vec<nexus_db_model::TufRepo>, HttpError> {
-        self.db_datastore
-            .tuf_repo_list_no_artifacts(opctx, pagparams)
-            .await
-            .map_err(HttpError::from)
+    ) -> Result<Vec<nexus_db_model::TufRepo>, Error> {
+        self.db_datastore.tuf_repo_list(opctx, pagparams).await
     }
 
     pub(crate) async fn updates_add_trust_root(