Skip to content

Conversation

@david-crespo
Copy link
Collaborator

@david-crespo david-crespo commented Oct 29, 2025

I put the SCIM token UI on dogfood and immediately noticed that the hex part of the token is 40 chars, not 20, because it's generated from 20 random bytes and each byte is two hex chars. This means we either have an ellipsis cut it off or let it go wide. I don't really like cutting it off, so I chose to go width="free" on the modal and cut down the length of the warning so it doesn't inflate the width further.

Before

image

After

image

@vercel
Copy link

vercel bot commented Oct 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
console Ready Ready Preview Oct 29, 2025 3:30pm

@david-crespo david-crespo changed the title Fix scim token copy modal Handle 40 char tokens in SCIM token copy modal Oct 29, 2025
@benjaminleonard
Copy link
Contributor

"free" made me uncomfortable because if we add more text to the message the modal will become too wide — I tried adding a wider modal variant but you need to give it extra space since the actual token width varies because it is not a mono font.

I settled on just adding a max width to the message content container.

@david-crespo david-crespo merged commit f95e29f into main Oct 29, 2025
7 checks passed
@david-crespo david-crespo deleted the scim-token-fix branch October 29, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants