Handle 40 char tokens in SCIM token copy modal #2955
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put the SCIM token UI on dogfood and immediately noticed that the hex part of the token is 40 chars, not 20, because it's generated from 20 random bytes and each byte is two hex chars. This means we either have an ellipsis cut it off or let it go wide. I don't really like cutting it off, so I chose to go
width="free"on the modal and cut down the length of the warning so it doesn't inflate the width further.Before
After