Skip to content

Commit 21a10c4

Browse files
committed
let's just wrap instead. this is why I'm not a designer
1 parent 9b6ffac commit 21a10c4

File tree

2 files changed

+16
-17
lines changed

2 files changed

+16
-17
lines changed

app/pages/system/UpdatePage.tsx

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import {
1414
SoftwareUpdate16Icon,
1515
SoftwareUpdate24Icon,
1616
Time16Icon,
17+
TimeOutline12Icon,
1718
} from '@oxide/design-system/icons/react'
1819
import { Badge } from '@oxide/design-system/ui'
1920

@@ -166,7 +167,7 @@ export default function UpdatePage() {
166167
</PropertiesTable.Row>
167168
</PropertiesTable>
168169

169-
<CardBlock className="min-w-160">
170+
<CardBlock>
170171
<CardBlock.Header title="Releases" />
171172
<CardBlock.Body>
172173
<ul className="space-y-3">
@@ -175,21 +176,21 @@ export default function UpdatePage() {
175176
return (
176177
<li
177178
key={repo.hash}
178-
className="border-secondary flex items-center gap-4 rounded border p-4"
179+
className="border-secondary flex items-center gap-3 rounded border p-4"
179180
>
180-
<Images24Icon className="text-secondary shrink-0" aria-hidden />
181-
<div className="flex-1">
182-
<div className="flex items-center gap-2">
183-
<span className="text-sans-semi-lg text-raise">
184-
{repo.systemVersion}
185-
</span>
186-
{isTarget && <Badge color="default">Target</Badge>}
181+
<Images24Icon className="text-tertiary shrink-0" aria-hidden />
182+
<div className="flex min-w-0 flex-1 flex-wrap items-center gap-x-4 gap-y-2">
183+
<div className="flex-1">
184+
<div className="flex items-center gap-2">
185+
<span className="text-sans-semi-lg text-raise">
186+
{repo.systemVersion}
187+
</span>
188+
{isTarget && <Badge color="default">Target</Badge>}
189+
</div>
190+
<div className="text-secondary">{repo.fileName}</div>
187191
</div>
188-
<div className="text-secondary">{repo.fileName}</div>
189-
</div>
190-
<div className="flex items-center gap-4">
191192
<div className="flex items-center gap-1">
192-
<Time16Icon aria-hidden />
193+
<TimeOutline12Icon className="text-tertiary mr-0.75" aria-hidden />
193194
<DateTime date={repo.timeCreated} />
194195
</div>
195196
</div>

app/ui/lib/CardBlock.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,14 @@ const widthClass: Record<Width, string> = {
2222
export type CardBlockProps = {
2323
children: ReactNode
2424
width?: Width
25-
className?: string
2625
}
2726

28-
export function CardBlock({ children, className, width = 'full' }: CardBlockProps) {
27+
export function CardBlock({ children, width = 'full' }: CardBlockProps) {
2928
return (
3029
<div
3130
className={cn(
3231
'text-sans-md border-default *:border-b-secondary flex flex-col rounded-lg border py-5 *:border-b last:*:border-0 last:*:pb-0',
33-
widthClass[width],
34-
className
32+
widthClass[width]
3533
)}
3634
>
3735
{children}

0 commit comments

Comments
 (0)