Make 0.14 CI green again
#919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruudk
force-pushed
the
fix-coverage
branch
7 times, most recently
from
c2eaad0 to
728da1d
Compare
Conditions should be quoted.
This requires `doctrine/annotations` to be installed.
Shouldn't be needed.
It's the default.
Much easier to use as it caches automatically. And it makes it possible to test lower and highest dependencies in the future.
Always use strings and no need for asterisk.
ruudk
force-pushed
the
fix-coverage
branch
3 times, most recently
from
aeef68c to
c868a21
Compare
mcg-web
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best to review per commit.