Add type-hints in annotation classes #729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vincz
requested changes
Aug 15, 2020
|
@murtukov |
|
@Vincz neither of these. I just don't have enough time for complex tasks, so I just go through code here and there and make simple improvements |
murtukov
force-pushed
the
enhancement/add-annotation-type-hints
branch
from
359ae51 to
c13a344
Compare
murtukov
force-pushed
the
enhancement/add-annotation-type-hints
branch
from
c13a344 to
aa8609a
Compare
Closed
Vincz
approved these changes
Aug 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type-hints to annotation classes + common refactoring
@Vincz please check the PR carefully, because I don't know everything, that happens in your code, therefore could make mistakes. I just added type-hints to annotation classes and made general changes in the annotation related code. Ask if you have any questions.