Merge pull request #700 from murtukov/enhancement/use-strict-access

Treat `useStrictAccess` option as true by default

Author: murtukov

src/Definition/ConfigProcessor/AclConfigProcessor.php

@@ -38,7 +38,7 @@ public static function acl(array $fields, AccessResolver $accessResolver, callab
                     $field['resolve'] = function ($value, $args, $context, ResolveInfo $info) use ($field, $accessChecker, $accessResolver, $defaultResolver) {
                         $resolverCallback = self::findFieldResolver($field, $info, $defaultResolver);
 
-                        return $accessResolver->resolve($accessChecker, $resolverCallback, [$value, $args, $context, $info], $field['useStrictAccess']);
+                        return $accessResolver->resolve($accessChecker, $resolverCallback, [$value, $args, $context, $info], $field['useStrictAccess'] ?? true);
                     };
                 }
             }

src/Generator/TypeBuilder.php

@@ -61,7 +61,6 @@
  * TODO (murtukov):
  *  1. Add <code> docblocks for every method
  *  2. Replace hard-coded string types with constants ('object', 'input-object' etc.).
- *  3. Change formatting of generated arguments.
  */
 class TypeBuilder
 {
@@ -94,9 +93,6 @@ public function __construct(ExpressionConverter $expressionConverter, string $na
         Config::registerConverter($expressionConverter, ConverterInterface::TYPE_STRING);
     }
 
-    /**
-     * TODO (murtukov). Implement file prototype to increase performance.
-     */
     public function build(array $config, string $type): PhpFile
     {
         $this->config = $config;
@@ -179,7 +175,7 @@ protected function buildConfigLoader(array $config): ArrowFunction
          * @var string|null   $description
          * @var array|null    $interfaces
          * @var string|null   $resolveType
-         * @var string|null   $validation   - only by InputType
+         * @var array|null    $validation   - only by InputType
          * @var array|null    $types        - only by UnionType
          * @var array|null    $values       - only by EnumType
          * @var callback|null $serialize    - only by CustomScalarType
@@ -566,8 +562,6 @@ public function buildField(array $fieldConfig /*, $fieldname */)
 
         if (!empty($access) && is_string($access) && ExpressionLanguage::expressionContainsVar('object', $access)) {
             $field->addItem('useStrictAccess', false);
-        } else {
-            $field->addItem('useStrictAccess', true);
         }
 
         if ('input-object' === $this->type && isset($validation)) {