Merge pull request #711 from mcg-web/simplify-fqcn-when-using-class_exists

Simplify FQCN when using class_exists

Author: mcg-web

src/Config/Parser/AnnotationParser.php

@@ -321,8 +321,8 @@ private static function typeAnnotationToGQLConfiguration(
     private static function getAnnotationReader(): AnnotationReader
     {
         if (null === self::$annotationReader) {
-            if (!class_exists('\\Doctrine\\Common\\Annotations\\AnnotationReader') ||
-                !class_exists('\\Doctrine\\Common\\Annotations\\AnnotationRegistry')) {
+            if (!class_exists(AnnotationReader::class) ||
+                !class_exists(AnnotationRegistry::class)) {
                 throw new RuntimeException('In order to use graphql annotation, you need to require doctrine annotations');
             }
 

src/DependencyInjection/OverblogGraphQLExtension.php

@@ -31,6 +31,7 @@
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
+use Symfony\Component\Validator\Validation;
 use function array_fill_keys;
 use function class_exists;
 use function realpath;
@@ -105,7 +106,7 @@ private function registerForAutoconfiguration(ContainerBuilder $container): void
 
     private function registerValidatorFactory(ContainerBuilder $container): void
     {
-        if (class_exists('Symfony\\Component\\Validator\\Validation')) {
+        if (class_exists(Validation::class)) {
             $container->register(ValidatorFactory::class)
                 ->setArguments([
                     new Reference('validator.validator_factory'),

tests/EventListener/ValidationErrorsListenerTest.php

@@ -12,6 +12,7 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Validator\ConstraintViolation;
 use Symfony\Component\Validator\ConstraintViolationList;
+use Symfony\Component\Validator\Validation;
 use function class_exists;
 
 class ValidationErrorsListenerTest extends TestCase
@@ -21,7 +22,7 @@ class ValidationErrorsListenerTest extends TestCase
 
     protected function setUp(): void
     {
-        if (!class_exists('Symfony\\Component\\Validator\\Validation')) {
+        if (!class_exists(Validation::class)) {
             $this->markTestSkipped('Symfony validator component is not installed');
         }
         $this->listener = new ValidationErrorsListener();

tests/ExpressionLanguage/ExpressionFunction/GraphQL/ArgumentsTest.php

@@ -15,6 +15,7 @@
 use Overblog\GraphQLBundle\Tests\Transformer\InputType1;
 use Overblog\GraphQLBundle\Tests\Transformer\InputType2;
 use Overblog\GraphQLBundle\Transformer\ArgumentsTransformer;
+use Symfony\Component\Validator\Validation;
 use Symfony\Component\Validator\Validator\RecursiveValidator;
 use function class_exists;
 use function count;
@@ -23,7 +24,7 @@ class ArgumentsTest extends TestCase
 {
     public function setUp(): void
     {
-        if (!class_exists('Symfony\\Component\\Validator\\Validation')) {
+        if (!class_exists(Validation::class)) {
             $this->markTestSkipped('Symfony validator component is not installed');
         }
         parent::setUp();

tests/Functional/Validator/InputValidatorTest.php

@@ -5,6 +5,7 @@
 namespace Overblog\GraphQLBundle\Tests\Functional\Validator;
 
 use Overblog\GraphQLBundle\Tests\Functional\TestCase;
+use Symfony\Component\Validator\Validation;
 use function class_exists;
 use function json_decode;
 
@@ -13,7 +14,7 @@ class InputValidatorTest extends TestCase
     protected function setUp(): void
     {
         parent::setUp();
-        if (!class_exists('Symfony\\Component\\Validator\\Validation')) {
+        if (!class_exists(Validation::class)) {
             $this->markTestSkipped('Symfony validator component is not installed');
         }
         static::bootKernel(['test_case' => 'validator']);

tests/Transformer/ArgumentsTransformerTest.php

@@ -16,6 +16,7 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Validator\ConstraintViolation;
 use Symfony\Component\Validator\ConstraintViolationList;
+use Symfony\Component\Validator\Validation;
 use Symfony\Component\Validator\Validator\RecursiveValidator;
 use function class_exists;
 use function count;
@@ -26,7 +27,7 @@ class ArgumentsTransformerTest extends TestCase
     protected function setUp(): void
     {
         parent::setUp();
-        if (!class_exists('Symfony\\Component\\Validator\\Validation')) {
+        if (!class_exists(Validation::class)) {
             $this->markTestSkipped('Symfony validator component is not installed');
         }
     }

tests/Validator/InputValidatorTest.php

@@ -9,14 +9,15 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException;
 use Symfony\Component\Validator\ConstraintValidatorFactory;
+use Symfony\Component\Validator\Validation;
 use function class_exists;
 
 class InputValidatorTest extends TestCase
 {
     public function setUp(): void
     {
         parent::setUp();
-        if (!class_exists('Symfony\\Component\\Validator\\Validation')) {
+        if (!class_exists(Validation::class)) {
             $this->markTestSkipped('Symfony validator component is not installed');
         }
     }

tests/Validator/Mapping/MetadataFactoryTest.php

@@ -11,13 +11,14 @@
 use PHPUnit\Framework\TestCase;
 use stdClass;
 use Symfony\Component\Validator\Exception\NoSuchMetadataException;
+use Symfony\Component\Validator\Validation;
 use function class_exists;
 
 class MetadataFactoryTest extends TestCase
 {
     public function setUp(): void
     {
-        if (!class_exists('Symfony\\Component\\Validator\\Validation')) {
+        if (!class_exists(Validation::class)) {
             $this->markTestSkipped('Symfony validator component is not installed');
         }
         parent::setUp();