chore: rename artifact_name to artifact_filename for clarity

Signed-off-by: Nathan Nguyen <[email protected]>

Author: nathanwn

src/macaron/artifact/maven.py

@@ -117,20 +117,20 @@ def from_package_url(cls, package_url: PackageURL) -> Self | None:
         )
 
     @classmethod
-    def from_artifact_name(
+    def from_artifact_filename(
         cls,
-        artifact_name: str,
+        artifact_filename: str,
         group_id: str,
         version: str,
     ) -> Self | None:
-        """Create a Maven artifact given an artifact name.
+        """Create a Maven artifact given an artifact filename.
 
         The artifact type is determined based on the naming pattern of the artifact.
 
         Parameters
         ----------
-        artifact_name : str
-            The artifact name.
+        artifact_filename : str
+            The filename of the artifact.
         group_id : str
             The group id.
         version : str
@@ -148,7 +148,7 @@ def from_artifact_name(
                 artifact_id="(.*)",
                 version=version,
             )
-            match_result = re.search(pattern, artifact_name)
+            match_result = re.search(pattern, artifact_filename)
             if not match_result:
                 continue
             artifact_id = match_result.group(1)
@@ -193,9 +193,9 @@ def get_subject_in_provenance_matching_purl(
 
             maven_artifact_subject_pairs = []
             for subject in artifact_subjects:
-                _, _, artifact_name = subject["name"].rpartition("/")
-                artifact = MavenArtifact.from_artifact_name(
-                    artifact_name=artifact_name,
+                _, _, artifact_filename = subject["name"].rpartition("/")
+                artifact = MavenArtifact.from_artifact_filename(
+                    artifact_filename=artifact_filename,
                     group_id=maven_artifact.group_id,
                     version=maven_artifact.version,
                 )

tests/artifact/test_maven.py

@@ -65,7 +65,7 @@ def test_maven_artifact_from_purl(purl_str: str, maven_artifact: MavenArtifact)
     [
         pytest.param(
             {
-                "artifact_name": "jackson-annotations-2.9.9.jar",
+                "artifact_filename": "jackson-annotations-2.9.9.jar",
                 "group_id": "com.fasterxml.jackson",
                 "version": "2.9.9",
             },
@@ -79,7 +79,7 @@ def test_maven_artifact_from_purl(purl_str: str, maven_artifact: MavenArtifact)
         ),
         pytest.param(
             {
-                "artifact_name": "jackson-annotations-2.9.9-javadoc.jar",
+                "artifact_filename": "jackson-annotations-2.9.9-javadoc.jar",
                 "group_id": "com.fasterxml.jackson",
                 "version": "2.9.9",
             },
@@ -93,7 +93,7 @@ def test_maven_artifact_from_purl(purl_str: str, maven_artifact: MavenArtifact)
         ),
         pytest.param(
             {
-                "artifact_name": "jackson-annotations-2.9.9-sources.jar",
+                "artifact_filename": "jackson-annotations-2.9.9-sources.jar",
                 "group_id": "com.fasterxml.jackson",
                 "version": "2.9.9",
             },
@@ -107,7 +107,7 @@ def test_maven_artifact_from_purl(purl_str: str, maven_artifact: MavenArtifact)
         ),
         pytest.param(
             {
-                "artifact_name": "jackson-annotations-2.9.9.pom",
+                "artifact_filename": "jackson-annotations-2.9.9.pom",
                 "group_id": "com.fasterxml.jackson",
                 "version": "2.9.9",
             },
@@ -123,7 +123,7 @@ def test_maven_artifact_from_purl(purl_str: str, maven_artifact: MavenArtifact)
 )
 def test_maven_artifact_from_artifact_name(params: dict, maven_artifact: MavenArtifact) -> None:
     """Test creating a ``MavenArtifact`` object given an artifact name."""
-    assert MavenArtifact.from_artifact_name(**params) == maven_artifact
+    assert MavenArtifact.from_artifact_filename(**params) == maven_artifact
 
 
 @pytest.mark.parametrize(