Skip to content

Commit f6adcca

Browse files
stellarhopperdjbw
authored andcommitted
libnvdimm, testing: update the default smart ctrl_temperature
The default value for smart ctrl_temperature was the same as the threshold for ctrl_temperature. As a result, any arbitrary smart injection to the nfit_test dimm could cause this alarm to trigger and cause an acpi notification. Drop the default value to below the threshold, so that unrelated injections don't trigger notifications. Cc: Dan Williams <[email protected]> Signed-off-by: Vishal Verma <[email protected]> Signed-off-by: Dan Williams <[email protected]>
1 parent 4cf260f commit f6adcca

File tree

1 file changed

+1
-1
lines changed
  • tools/testing/nvdimm/test

1 file changed

+1
-1
lines changed

tools/testing/nvdimm/test/nfit.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1259,7 +1259,7 @@ static void smart_init(struct nfit_test *t)
12591259
| ND_INTEL_SMART_MTEMP_VALID,
12601260
.health = ND_INTEL_SMART_NON_CRITICAL_HEALTH,
12611261
.media_temperature = 23 * 16,
1262-
.ctrl_temperature = 30 * 16,
1262+
.ctrl_temperature = 25 * 16,
12631263
.pmic_temperature = 40 * 16,
12641264
.spares = 75,
12651265
.alarm_flags = ND_INTEL_SMART_SPARE_TRIP

0 commit comments

Comments
 (0)