Skip to content

Commit c4faa71

Browse files
masneybSherryYang1
authored andcommitted
rtc: pcf8563: fix incorrect maximum clock rate handling
[ Upstream commit 906726a ] When pcf8563_clkout_round_rate() is called with a requested rate higher than the highest supported rate, it currently returns 0, which disables the clock. According to the clk API, round_rate() should instead return the highest supported rate. Update the function to return the maximum supported rate in this case. Fixes: a39a640 ("rtc: pcf8563: add CLKOUT to common clock framework") Signed-off-by: Brian Masney <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]> Signed-off-by: Sasha Levin <[email protected]> (cherry picked from commit 75024aae0ee5b8f90798352aef022e11e939512a) Signed-off-by: Sherry Yang <[email protected]>
1 parent 68f78d5 commit c4faa71

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/rtc/rtc-pcf8563.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ static long pcf8563_clkout_round_rate(struct clk_hw *hw, unsigned long rate,
421421
if (clkout_rates[i] <= rate)
422422
return clkout_rates[i];
423423

424-
return 0;
424+
return clkout_rates[0];
425425
}
426426

427427
static int pcf8563_clkout_set_rate(struct clk_hw *hw, unsigned long rate,

0 commit comments

Comments
 (0)