remove unnecessary TruffleBoundary for intrinsified call to arrayCopy

- reduce amount of inlined java lib code (ArrayList)

- style fix

Author: cosminbasca

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinConstructors.java

@@ -1474,7 +1474,8 @@ public PZip zip(PythonClass cls, Object[] args,
     }
 
     // function(code, globals[, name[, argdefs[, closure]]])
-    @Builtin(name = "function", minNumOfPositionalArgs = 3, maxNumOfPositionalArgs = 6, constructsClass = {PythonBuiltinClassType.PFunction, PythonBuiltinClassType.PGeneratorFunction}, isPublic = false)
+    @Builtin(name = "function", minNumOfPositionalArgs = 3, maxNumOfPositionalArgs = 6, constructsClass = {PythonBuiltinClassType.PFunction,
+                    PythonBuiltinClassType.PGeneratorFunction}, isPublic = false)
     @GenerateNodeFactory
     public abstract static class FunctionNode extends PythonBuiltinNode {
 
@@ -1498,7 +1499,8 @@ public PFunction function(Object cls, Object method_def, Object def, Object name
 
     // type(object)
     // type(object, bases, dict)
-    @Builtin(name = TYPE, minNumOfPositionalArgs = 2, maxNumOfPositionalArgs = 4, takesVarKeywordArgs = true, constructsClass = {PythonBuiltinClassType.PythonClass, PythonBuiltinClassType.PythonBuiltinClass})
+    @Builtin(name = TYPE, minNumOfPositionalArgs = 2, maxNumOfPositionalArgs = 4, takesVarKeywordArgs = true, constructsClass = {PythonBuiltinClassType.PythonClass,
+                    PythonBuiltinClassType.PythonBuiltinClass})
     @GenerateNodeFactory
     public abstract static class TypeNode extends PythonBuiltinNode {
         @Specialization(guards = {"isNoValue(bases)", "isNoValue(dict)"})
@@ -1935,7 +1937,8 @@ protected boolean isMapping(Object o) {
         }
     }
 
-    @Builtin(name = "getset_descriptor", constructsClass = {PythonBuiltinClassType.GetSetDescriptor}, isPublic = false, fixedNumOfPositionalArgs = 1, keywordArguments = {"fget", "fset", "name", "owner"})
+    @Builtin(name = "getset_descriptor", constructsClass = {PythonBuiltinClassType.GetSetDescriptor}, isPublic = false, fixedNumOfPositionalArgs = 1, keywordArguments = {"fget", "fset", "name",
+                    "owner"})
     @GenerateNodeFactory
     @SuppressWarnings("unused")
     public abstract static class GetSetDescriptorNode extends PythonBuiltinNode {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/argument/ApplyKeywordsNode.java

@@ -40,15 +40,14 @@
  */
 package com.oracle.graal.python.nodes.argument;
 
-import java.util.ArrayList;
+import java.util.Arrays;
 
 import com.oracle.graal.python.builtins.objects.function.Arity;
 import com.oracle.graal.python.builtins.objects.function.PArguments;
 import com.oracle.graal.python.builtins.objects.function.PKeyword;
 import com.oracle.graal.python.nodes.PBaseNode;
 import com.oracle.graal.python.nodes.argument.ApplyKeywordsNodeGen.SearchNamedParameterNodeGen;
 import com.oracle.graal.python.runtime.exception.PythonErrorType;
-import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.dsl.Cached;
 import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.nodes.ExplodeLoop;
@@ -72,11 +71,6 @@ SearchNamedParameterNode createSearchNamedParameterNode() {
         return SearchNamedParameterNodeGen.create();
     }
 
-    @TruffleBoundary
-    private static void copyArgs(Object[] src, Object[] dst, int len) {
-        System.arraycopy(src, 0, dst, 0, len);
-    }
-
     @Specialization(guards = {"kwLen == keywords.length", "argLen == arguments.length", "calleeArity == cachedArity"})
     @ExplodeLoop
     Object[] applyCached(Arity calleeArity, Object[] arguments, PKeyword[] keywords,
@@ -90,10 +84,11 @@ Object[] applyCached(Arity calleeArity, Object[] arguments, PKeyword[] keywords,
         Object[] combined = arguments;
         if (expandArgs.profile(paramLen > userArgLen)) {
             combined = PArguments.create(paramLen);
-            copyArgs(arguments, combined, argLen);
+            System.arraycopy(arguments, 0, combined, 0, argLen);
         }
 
-        ArrayList<PKeyword> unusedKeywords = new ArrayList<>();
+        PKeyword[] unusedKeywords = new PKeyword[kwLen];
+        int k = 0;
         for (int i = 0; i < kwLen; i++) {
             PKeyword kwArg = keywords[i];
             int kwIdx = searchParamNode.execute(parameters, kwArg.getName());
@@ -106,10 +101,10 @@ Object[] applyCached(Arity calleeArity, Object[] arguments, PKeyword[] keywords,
                 }
                 PArguments.setArgument(combined, kwIdx, kwArg.getValue());
             } else {
-                unusedKeywords.add(kwArg);
+                unusedKeywords[k++] = kwArg;
             }
         }
-        PArguments.setKeywordArguments(combined, unusedKeywords.toArray(new PKeyword[unusedKeywords.size()]));
+        PArguments.setKeywordArguments(combined, Arrays.copyOf(unusedKeywords, k));
         return combined;
     }
 
@@ -122,7 +117,8 @@ Object[] applyUncached(Arity calleeArity, Object[] arguments, PKeyword[] keyword
             System.arraycopy(arguments, 0, combined, 0, arguments.length);
         }
 
-        ArrayList<PKeyword> unusedKeywords = new ArrayList<>();
+        PKeyword[] unusedKeywords = new PKeyword[keywords.length];
+        int k = 0;
         for (int i = 0; i < keywords.length; i++) {
             PKeyword kwArg = keywords[i];
             int kwIdx = -1;
@@ -139,10 +135,10 @@ Object[] applyUncached(Arity calleeArity, Object[] arguments, PKeyword[] keyword
                 }
                 PArguments.setArgument(combined, kwIdx, kwArg.getValue());
             } else {
-                unusedKeywords.add(kwArg);
+                unusedKeywords[k++] = kwArg;
             }
         }
-        PArguments.setKeywordArguments(combined, unusedKeywords.toArray(new PKeyword[unusedKeywords.size()]));
+        PArguments.setKeywordArguments(combined, Arrays.copyOf(unusedKeywords, k));
         return combined;
     }