fix crashing traceback tests; assert materialize frame location is valid Node

Author: DSouzaM

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/frame/PFrame.java

@@ -309,7 +309,7 @@ public int getLasti() {
     @TruffleBoundary
     public static int bciToLasti(int bci, Node location) {
         if (PythonOptions.ENABLE_BYTECODE_DSL_INTERPRETER) {
-            if (location instanceof BytecodeNode bytecodeNode) {
+            if (bci >= 0 && location instanceof BytecodeNode bytecodeNode) {
                 // Emulate CPython's fixed 2-word instructions.
                 return bytecodeNode.findInstructionIndex(bci) * 2;
             }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/generator/CommonGeneratorBuiltins.java

@@ -67,6 +67,7 @@
 import com.oracle.graal.python.nodes.bytecode.FrameInfo;
 import com.oracle.graal.python.nodes.bytecode.GeneratorReturnException;
 import com.oracle.graal.python.nodes.bytecode.GeneratorYieldResult;
+import com.oracle.graal.python.nodes.bytecode_dsl.PBytecodeDSLRootNode;
 import com.oracle.graal.python.nodes.call.CallTargetInvokeNode;
 import com.oracle.graal.python.nodes.call.GenericInvokeNode;
 import com.oracle.graal.python.nodes.frame.MaterializeFrameNode;
@@ -404,7 +405,7 @@ static Object sendThrow(VirtualFrame frame, PGenerator self, Object typ, Object
                 PTraceback newTraceback = factory.get(inliningTarget).createTraceback(pFrame, pFrame.getLine(),
                                 (existingTracebackObj instanceof PTraceback existingTraceback) ? existingTraceback : null);
                 setTracebackNode.execute(inliningTarget, instance, newTraceback);
-                throw PException.fromObject(instance, location, PythonOptions.isPExceptionWithJavaStacktrace(language));
+                throw PException.fromObject(instance, inliningTarget, PythonOptions.isPExceptionWithJavaStacktrace(language));
             }
         }
     }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/bytecode_dsl/PBytecodeDSLRootNode.java

@@ -319,8 +319,9 @@ public static void doEnter(VirtualFrame frame,
     public static final class ExitCalleeContext {
         @Specialization
         public static Object doExit(VirtualFrame frame, Object returnValue,
-                        @Bind("$root") PBytecodeDSLRootNode root) {
-            root.calleeContext.exit(frame, root);
+                        @Bind("$root") PBytecodeDSLRootNode root,
+                        @Bind("this") Node location) {
+            root.calleeContext.exit(frame, root, location);
             return returnValue;
         }
     }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/frame/MaterializeFrameNode.java

@@ -50,6 +50,7 @@
 import com.oracle.graal.python.runtime.object.PythonObjectFactory;
 import com.oracle.graal.python.util.PythonUtils;
 import com.oracle.truffle.api.Truffle;
+import com.oracle.truffle.api.bytecode.BytecodeLocation;
 import com.oracle.truffle.api.bytecode.BytecodeNode;
 import com.oracle.truffle.api.dsl.Bind;
 import com.oracle.truffle.api.dsl.Cached;
@@ -181,8 +182,13 @@ private static void processBytecodeFrame(Frame frameToMaterialize, PFrame pyFram
         if (PythonOptions.ENABLE_BYTECODE_DSL_INTERPRETER) {
             BytecodeDSLFrameInfo bytecodeDSLFrameInfo = (BytecodeDSLFrameInfo) info;
             PBytecodeDSLRootNode rootNode = bytecodeDSLFrameInfo.getRootNode();
+            if (location instanceof PBytecodeDSLRootNode) {
+                throw new AssertionError("The root node was passed as a location, but the root node is insufficient for identifying a bytecode location.");
+            } else if (location.getRootNode() != rootNode) {
+                throw new AssertionError("A node that did not belong to this root node was passed as a location.");
+            }
             BytecodeNode bytecodeNode = BytecodeNode.get(location);
-            pyFrame.setBci(rootNode.readBciFromFrame(frameToMaterialize));
+            pyFrame.setBci(bytecodeNode.getBytecodeLocation(frameToMaterialize, location).getBytecodeIndex());
             pyFrame.setLocation(bytecodeNode);
         } else {
             BytecodeFrameInfo bytecodeFrameInfo = (BytecodeFrameInfo) info;