Use CRLF by default on win32 in TextIOWrapper

(cherry picked from commit c5131fd)

Author: msimacek

graalpython/com.oracle.graal.python.test/src/tests/test_io.py

@@ -36,9 +36,11 @@
 # LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
-
-import unittest
 import _io
+import os
+import sys
+import tempfile
+import unittest
 
 
 class IOBaseTests(unittest.TestCase):
@@ -312,6 +314,17 @@ def read(self, n=None):
         t = _io.TextIOWrapper(MockRawIO(), newline="\r\n")
         self.assertEqual(["ab\r\n", "cd"], t.readlines())
 
+    @unittest.skipIf(sys.platform != "win32", "Windows-only test")
+    def test_crlf_default_on_win32(self):
+        with tempfile.TemporaryDirectory() as d:
+            path = os.path.join(d, "tmp")
+            with open(path, 'w') as f:
+                f.write("hello\nworld\n")
+            with open(path, 'rb') as f:
+                self.assertEqual(f.read(), b"hello\r\nworld\r\n")
+            with open(path, 'r') as f:
+                self.assertEqual(f.read(), "hello\nworld\n")
+
 
 if __name__ == '__main__':
     unittest.main()

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/io/TextIOWrapperNodes.java

@@ -67,6 +67,7 @@
 import static com.oracle.graal.python.nodes.ErrorMessages.S_SHOULD_HAVE_RETURNED_A_BYTES_LIKE_OBJECT_NOT_P;
 import static com.oracle.graal.python.nodes.PGuards.isPNone;
 import static com.oracle.graal.python.nodes.SpecialMethodNames.T_DECODE;
+import static com.oracle.graal.python.nodes.StringLiterals.T_CRLF;
 import static com.oracle.graal.python.nodes.StringLiterals.T_EMPTY_STRING;
 import static com.oracle.graal.python.nodes.StringLiterals.T_NEWLINE;
 import static com.oracle.graal.python.nodes.StringLiterals.T_STRICT;
@@ -77,6 +78,7 @@
 import static com.oracle.graal.python.util.PythonUtils.tsLiteral;
 
 import com.oracle.graal.python.PythonLanguage;
+import com.oracle.graal.python.builtins.PythonOS;
 import com.oracle.graal.python.builtins.modules.CodecsTruffleModuleBuiltins;
 import com.oracle.graal.python.builtins.modules.CodecsTruffleModuleBuiltins.MakeIncrementalcodecNode;
 import com.oracle.graal.python.builtins.modules.WarningsModuleBuiltins;
@@ -153,7 +155,11 @@ protected static void setNewline(PTextIO self, TruffleString newline, TruffleStr
                 self.setWriteNewline(self.getReadNewline());
             }
         } else {
-            self.setWriteNewline(null);
+            if (PythonOS.getPythonOS() == PythonOS.PLATFORM_WIN32) {
+                self.setWriteNewline(T_CRLF);
+            } else {
+                self.setWriteNewline(null);
+            }
         }
     }