[GR-49410] Do not mark AnalysisType reachable when creating AnalysisField. #8011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
cwi/GR-49410-cleanups
branch
from
b2203ac to
8716e0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows late registration of
FieldValueTransformerwithout aComputedValueField. This removes the need to mark a type a reachable before creating its first field. In particular, two places can create field value transformers late (while the analysis is already running):FieldValueTransformer. This API is specified to allow registration in the reachability handler of that type.These two places are changed to use the new
FieldValueInterceptionSupport. For now, we keepComputedValueFieldbut eventually we want to remove it completely.