Omit internal jdk.JavaMonitorWait JFR events #7518
Merged
+37
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
fniephaus
reviewed
Oct 9, 2023
...tratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jfr/events/JavaMonitorWaitEvent.java
Outdated
Show resolved
Hide resolved
…r/events/JavaMonitorWaitEvent.java Co-authored-by: Fabio Niephaus <[email protected]>
Member
christianhaeubl
left a comment
christianhaeubl
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Instead of doing a string comparison, please directly compare the class objects (the String comparison will fail silently if the JDK code changes). You will need to create a @TargetClass for jdk.jfr.internal.JVM$ChunkRotationMonitor.
Member
|
Thanks, this PR will be merged to master in the next few days. |
christianhaeubl
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a very minor change to replicate the behavior in OpenJDK by omitting internal
jdk.JavaMonitorWaitevents emitted by the JFR periodic task. This basically just reduces some noise, especially when the application is idle.Bugzilla: https://bugs.openjdk.org/browse/JDK-8286707?jql=text%20~%20%22jfr%22
OpenJDK PR: openjdk/jdk#8883
See before (sorted by thread name):
And after:
