Fix reading cgroup controller error #6381
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple controllers can be set on the same hierarchy in /proc/self/cgroup. Assume a few fixed patterns is not sufficient to handle all the cases.
oracle-contributor-agreement
bot
added
the
OCA Verified
Member
|
Thank you @ziyilin for opening this PR, |
|
How is this handled / fixed in OpenJDK (where our code is copied from)? |
Collaborator
Author
|
Although not exactly the same, OpenJDK17 uses the similar approach as this PR to handle the problem. |
Collaborator
Author
|
Hi @christianwimmer, is there any review updates? |
|
We are working on a solution that brings our code closer to the JDK again (ideally just using the JDK code). |
|
Is there any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple controllers can be set on the same hierarchy in /proc/self/cgroup. Assume a few fixed patterns is not sufficient to handle all the cases.
The related issue is: #6382