Skip to content

Conversation

@zakkak
Copy link
Collaborator

@zakkak zakkak commented Aug 7, 2020

As of mx 5.270.0 (graalvm/mx#221), mx projects can be built even outside a vcs repository.
This patch makes the necessary changes to allow graal to be built outside a vcs repository.

As of mx 5.270.0, mx projects can be built even outside a vcs
repository.
This patch makes the necessary changes to allow graal to be built
outside a vcs repository.
@dougxc
Copy link
Member

dougxc commented Aug 10, 2020

Is there some way we can test this in Travis? Maybe rm -rf .git before running some tests?

@dougxc dougxc self-assigned this Aug 10, 2020
@dougxc
Copy link
Member

dougxc commented Aug 10, 2020

Don't we need to place a .mx_vcs_root file in the root directory?

@zakkak
Copy link
Collaborator Author

zakkak commented Aug 10, 2020

Is there some way we can test this in Travis? Maybe rm -rf .git before running some tests?

There is this graalvm/mx#216

Don't we need to place a .mx_vcs_root file in the root directory?

No it works both with .mx_vcs_root and ci.hocon

@dougxc
Copy link
Member

dougxc commented Aug 10, 2020

There is this graalvm/mx#216

I would suggest moving/copying that gate task to the graal repo itself so that it is run for every Graal change, not just every mx change (which are less frequent).

No it works both with .mx_vcs_root and ci.hocon

At some point, I think we want to break the unnatural coupling to the existence of ci.hocon so would prefer that Graal has its own .mx_vcs_root file.

@zakkak
Copy link
Collaborator Author

zakkak commented Aug 10, 2020

@dougxc thanks for the feedback I fixed the comments in e961575 (not a travis user so please let me know if there is a better way to achieve this)

@zakkak zakkak force-pushed the master-build-with-no-repo branch 2 times, most recently from 13dd1ea to 447f130 Compare August 11, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants