Skip to content

[GR-65192] Recurring callback fixes. #11571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2025
Merged

[GR-65192] Recurring callback fixes. #11571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...tevm/src/com.oracle.svm.core/src/com/oracle/svm/core/thread/RecurringCallbackSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,10 @@ private void maybeExecuteCallback() {
/*
* Before executing the callback, reset the safepoint requested counter as we
* don't want to trigger another callback execution in the near future.
*
* Recurring callbacks typically execute VM-internal code that performs hardly
* any safepoint checks. We explicitly don't update the recurring callback
* statistics anywhere in this method as this could skew the numbers.
*/
setCounter(SafepointCheckCounter.MAX_VALUE);
try {
Expand All @@ -364,7 +368,6 @@ private void maybeExecuteCallback() {
*/
} finally {
lastCallbackExecution = System.nanoTime();
updateStatistics();
}
}
} finally {
Expand Down
7 changes: 5 additions & 2 deletions ...tratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/thread/SafepointCheckCounter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,11 @@
*/
public class SafepointCheckCounter {
private static final FastThreadLocalInt valueTL = FastThreadLocalFactory.createInt("SafepointCheckCounter.value").setMaxOffset(FastThreadLocal.FIRST_CACHE_LINE);
/** Can be used to reset the thread-local value after a safepoint. */
static final int MAX_VALUE = Integer.MAX_VALUE;
/**
* Can be used to reset the thread-local value after a safepoint. We explicitly keep some
* distance to {@link Integer#MAX_VALUE} to avoid corner cases.
*/
static final int MAX_VALUE = Integer.MAX_VALUE >>> 1;

@Uninterruptible(reason = CALLED_FROM_UNINTERRUPTIBLE_CODE, mayBeInlined = true)
static boolean compareAndSet(IsolateThread thread, int oldValue, int newValue) {
Expand Down