[GR-63596] Treat "name" entries in legacy configuration files like "type" in reachability-metadata.json #11332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chability-metadata.json
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the parsing of
reflection-config.jsonunder--future-defaults. This change will eventually allow us to always consider"name"entries inreflection-config.jsonthe same way as"type"entries inreachability-metadata.json, which will enable us to get rid of a large quantity of code related to the parsing and registration of reflection metadata for classes, such as the concept of "queried only" methods and fields, as well as the conditional inclusion of record components, permitted subclasses or nest members.Community impact
Running the reachability metadata repository tests with
"name"being interpreted as"type"caused only one issue: an analysis failure regarding a type not found during analysis, which is probably a bug on our side and not something that would require a modification of reachability metadata. This is a good sign that such a change is unlikely to cause major problems when it is being made a default.