Skip to content

Conversation

@jerboaa
Copy link
Collaborator

@jerboaa jerboaa commented Feb 18, 2025

Closes #10708

Tested with (which failed earlier):

$ mx --primary-suite-path substratevm --no-jlinking build
$ GRAALVM_HOME=$(mx --primary-suite-path substratevm --no-jlinking graalvm-home)
$ $GRAALVM_HOME/bin/native-image --macro:native-image-agent-library
[...]
Top 10 origins of code area:                                Top 10 object types in image heap:
   6.81MB java.base                                            2.53MB byte[] for code metadata
   1.51MB svm.jar (Native Image)                               1.78MB byte[] for java.lang.String
 309.98kB org.graalvm.nativeimage.configure                    1.23MB java.lang.String
 235.73kB org.graalvm.nativeimage.agent.tracing              937.73kB com.oracle.svm.core.hub.DynamicHubCompanion
 224.31kB jdk.zipfs                                          678.06kB byte[] for general heap data
 106.37kB java.logging                                       649.54kB java.lang.Class
  75.07kB org.graalvm.nativeimage.base                       362.40kB java.util.HashMap$Node
  71.10kB jdk.charsets                                       292.18kB java.lang.Object[]
  49.80kB jdk.proxy2                                         234.43kB java.util.concurrent.ConcurrentHashMap$Node
  49.60kB jdk.graal.compiler                                 226.22kB java.util.HashMap$Node[]
 141.53kB for 9 more packages                                  2.81MB for 1376 more object types
------------------------------------------------------------------------------------------------------------------------
Recommendations:
 HEAP: Set max heap for improved and more predictable memory usage.
------------------------------------------------------------------------------------------------------------------------
                        2.1s (5.1% of total time) in 316 GCs | Peak RSS: 1.92GB | CPU load: 8.62
------------------------------------------------------------------------------------------------------------------------
Build artifacts:
 /disk/graal/upstream-sources/graal/sdk/mxbuild/linux-amd64/GRAALVM_757AAB922C_JAVA25/graalvm-757aab922c-java25-25.0.0-dev/lib/gdb-debughelpers.py (debug_info)
 /disk/graal/upstream-sources/graal/sdk/mxbuild/linux-amd64/GRAALVM_757AAB922C_JAVA25/graalvm-757aab922c-java25-25.0.0-dev/lib/graal_isolate.h (c_header)
 /disk/graal/upstream-sources/graal/sdk/mxbuild/linux-amd64/GRAALVM_757AAB922C_JAVA25/graalvm-757aab922c-java25-25.0.0-dev/lib/graal_isolate_dynamic.h (c_header)
 /disk/graal/upstream-sources/graal/sdk/mxbuild/linux-amd64/GRAALVM_757AAB922C_JAVA25/graalvm-757aab922c-java25-25.0.0-dev/lib/libnative-image-agent.h (c_header)
 /disk/graal/upstream-sources/graal/sdk/mxbuild/linux-amd64/GRAALVM_757AAB922C_JAVA25/graalvm-757aab922c-java25-25.0.0-dev/lib/libnative-image-agent.so (shared_library)
 /disk/graal/upstream-sources/graal/sdk/mxbuild/linux-amd64/GRAALVM_757AAB922C_JAVA25/graalvm-757aab922c-java25-25.0.0-dev/lib/libnative-image-agent.so.debug (debug_info)
 /disk/graal/upstream-sources/graal/sdk/mxbuild/linux-amd64/GRAALVM_757AAB922C_JAVA25/graalvm-757aab922c-java25-25.0.0-dev/lib/libnative-image-agent_dynamic.h (c_header)
 /disk/graal/upstream-sources/graal/sdk/mxbuild/linux-amd64/GRAALVM_757AAB922C_JAVA25/graalvm-757aab922c-java25-25.0.0-dev/lib/sources (debug_info)
========================================================================================================================
Finished generating 'libnative-image-agent' in 40.1s.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 18, 2025
@jerboaa jerboaa requested review from zakkak and zapster February 18, 2025 14:34
@jerboaa
Copy link
Collaborator Author

jerboaa commented Feb 18, 2025

Trivial change after #10380 to fix the Mandrel for JDK 25 build.

@zapster zapster requested review from dougxc and olpaw February 18, 2025 14:48
Copy link
Member

@dougxc dougxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zapster
Copy link
Member

zapster commented Feb 18, 2025

Thanks for the review @dougxc. I'll take care of integrating it.

@jerboaa
Copy link
Collaborator Author

jerboaa commented Feb 18, 2025

Thanks for the reviews and the help getting this integrated.

Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Thanks @jerboaa

@graalvmbot graalvmbot merged commit 8271b09 into oracle:master Feb 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement. redhat-interest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Native Image] non-jlinked base JDKs don't find module org.graalvm.nativeimage.libgraal

5 participants